Several QOL changes for plots #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saramonzon
reviewed
Jan 3, 2025
![codecov-ai[bot]](https://avatars.githubusercontent.com/in/797565?s=60&v=4){kind=small}
Comment on lines
+71
to
+72
| if "xaxis" in options: | ||
| fig.update_layout(xaxis=options["xaxis"]) |
There was a problem hiding this comment.
The current implementation directly updates the layout of the figure if 'xaxis' is present in the options. This can be made more robust by using the update method of the dictionary to avoid potential key errors and to make the code more readable.
Suggested change
| if "xaxis" in options: | |
| fig.update_layout(xaxis=options["xaxis"]) | |
| fig.update_layout({ | |
| xaxis: options.get("xaxis", {}) | |
| }) |
| @@ -33,15 +32,13 @@ def create_samples_received_map(): | |||
| "received_samples_map" | |||
| ) | |||
|
|
|||
| ldata = pd.DataFrame(json_data) | |||
|
|
|||
| fig = px.choropleth_mapbox( | |||
There was a problem hiding this comment.
The removal of the DataFrame conversion for json_data might cause issues if json_data is not in the expected format. Ensure that json_data is a dictionary with the required keys.
| @@ -104,7 +104,7 @@ def create_needle_plot_graph_mutation_by_lineage( | |||
| mutationData=mdata, | |||
| rangeSlider=True, | |||
| xlabel="Genome Position", | |||
| ylabel="Population Allele Frequency samples", | |||
| ylabel="Population Allele Frequency", | |||
There was a problem hiding this comment.
The label 'Population Allele Frequency samples' seems to be a typo. The corrected label 'Population Allele Frequency' is more appropriate.
saramonzon
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several changes:
Speed up intranet/received_samples page by including samples_map in graphicJsons and improving the queries for received_samples_with_date(), which also has been changed to show created_at dates instead of sequencing_dates (Closes received samples per date graph is limited to 2021 #175 )
Included host-info data in graphic json to speed up the loading time
Included the number of samples represented for each lineage in Lineage-Variants dashboard plot