Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented changes described in comments in the previous PR #13

Merged
merged 50 commits into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
c29337a
Update analyze schema with Comments in previous PR. Added liting work…
luissian Jan 8, 2024
92f379b
fixiing some liting
luissian Jan 8, 2024
e1ed738
fixiing more liting errors
luissian Jan 8, 2024
1d86220
changed file extension for old python files
luissian Jan 8, 2024
c18365d
fixing latest liting
luissian Jan 8, 2024
54533b1
fixing latest liting 2
luissian Jan 8, 2024
1da9102
fixing latest liting 3
luissian Jan 8, 2024
cfcc652
checking liting in functions which are defined the type of variable
luissian Jan 16, 2024
eb00782
Checking testing file
luissian Jan 17, 2024
d732fa0
first draft to run test
luissian Jan 17, 2024
dccedc1
first draft to run test
luissian Jan 17, 2024
b19266d
added deps to github action test
luissian Jan 17, 2024
5f4e2ef
Updated test and environment for conda installation
luissian Jan 17, 2024
8b70dbe
Removed python packages from conda and move to pip
luissian Jan 17, 2024
e8eecd0
remove Self from annotation
luissian Jan 17, 2024
f2ef7ad
liting
luissian Jan 17, 2024
84a52d3
Updated with comments in PR#13. Adding testing analyze schema with te…
luissian Jan 22, 2024
917df0a
fixing liting and error testing
luissian Jan 22, 2024
e599433
Again trying to fix liting and testing
luissian Jan 22, 2024
174da64
modified schema input parameter
luissian Jan 22, 2024
12cfabc
correcting wrong path of schema
luissian Jan 22, 2024
dc9b272
including echo ls to know which is the working path
luissian Jan 22, 2024
8678110
including ls to know which is the working path
luissian Jan 22, 2024
a6254bc
removing variable
luissian Jan 22, 2024
88f4de8
activate conda environment
luissian Jan 22, 2024
b022f43
added conda init before activate conda base
luissian Jan 22, 2024
db76c5b
activte conda env with the source command and the activate
luissian Jan 22, 2024
e372796
testing how to run prokka
luissian Jan 22, 2024
002ca49
testing how to run prokka_2
luissian Jan 22, 2024
397da09
testing 1
luissian Jan 22, 2024
58d7bad
test2
luissian Jan 22, 2024
d3f53c4
test3
luissian Jan 22, 2024
ba3276e
test4
luissian Jan 22, 2024
983a7d5
test5
luissian Jan 22, 2024
00f8692
test5
luissian Jan 22, 2024
0003585
test6
luissian Jan 22, 2024
55dbd45
added kaleido package
luissian Jan 22, 2024
573a253
Udpated code with latest comment in PR
luissian Jan 23, 2024
a740b91
replace deprecate setup.py for pyproject.toml
luissian Jan 24, 2024
c8dcc7f
reduce the 2 loop for checking the duplicated and sub allele
luissian Jan 25, 2024
33130e2
remove unnecesary comments
luissian Jan 25, 2024
98a1f63
testing new pyproject.toml file
luissian Jan 25, 2024
6cabd24
fixing liting and update test
luissian Jan 25, 2024
ef0f2b7
update installation taranis for testing
luissian Jan 25, 2024
a8ae894
include all command in the same run
luissian Jan 25, 2024
9b34397
Split the number of cpus used for prokka and app
luissian Jan 25, 2024
22096fa
commit to start with reference allele feature
luissian Jan 28, 2024
86fbcdc
Including poetry.lock in gitignore
luissian Jan 28, 2024
4a0a754
Fixing liting
luissian Jan 28, 2024
0572e69
Fixing liting
luissian Jan 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .github/workflows/dockerhub_push_release.yml

This file was deleted.

35 changes: 35 additions & 0 deletions .github/workflows/python_lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: python_lint

on:
push:
paths:
- '**.py'
pull_request:
paths:
- '**.py'

jobs:
flake8_py3:
runs-on: ubuntu-latest
steps:
- name: Setup Python
uses: actions/setup-python@v1
with:
python-version: 3.9.x
architecture: x64
- name: Checkout PyTorch
uses: actions/checkout@master
- name: Install flake8
run: pip install flake8
- name: Run flake8
run: flake8 --ignore E501,W503,E203,W605

black_lint:
runs-on: ubuntu-latest
steps:
- name: Setup
uses: actions/checkout@v2
- name: Install black in jupyter
run: pip install black[jupyter]
- name: Check code lints with Black
uses: psf/black@stable
51 changes: 22 additions & 29 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -1,38 +1,31 @@
name: tests ci
# This workflow runs the pipeline with the minimal test dataset to check that it completes any errors
# This workflow runs the pipeline with the minimal test dataset to check
# is completed without any errors
on:
push:
branches: [develop]
pull_request_target:
branches: [develop]
release:
types: [published]
pull_request:
push:

jobs:
push_dockerhub:
name: Push new Docker image to Docker Hub (dev)
test_analyze_schema:
runs-on: ubuntu-latest
# Only run for the official repo, for releases and merged PRs
if: ${{ github.repository == 'BU-ISCIII/taranis' }}
env:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_PASS: ${{ secrets.DOCKERHUB_PASSWORD }}

steps:
- name: Check out pipeline code
uses: actions/checkout@v2
- name: Checkout repository
uses: actions/checkout@v4

- name: Build new docker image
run: docker build --no-cache . -t buisciii/taranis:dev
- name: Set up Miniconda
uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: taranis_env
environment-file: environment.yml

- name: Push Docker image to DockerHub (develop)
run: |
echo "$DOCKERHUB_PASS" | docker login -u "$DOCKERHUB_USERNAME" --password-stdin
docker push buisciii/taranis:dev
run-tests:
name: Run tests
needs: push_dockerhub
runs-on: ubuntu-latest
steps:
- name: Run pipeline with test data
- name: Verify Conda environment
run: conda env list

- name: Activate env and install taranis
run: |
docker run buisciii/taranis:dev bash -c /opt/taranis/test/test.sh
source $CONDA/etc/profile.d/conda.sh
conda activate taranis_env
poetry install
taranis analyze-schema -i test/MLST_listeria -o analyze_schema_test --cpus 1 --output-allele-annot --remove-no-cds --remove-duplicated --remove-subset

1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ wheels/
.installed.cfg
*.egg
MANIFEST
poetry.lock

# PyInstaller
# Usually these files are written by a python script from a template
Expand Down
15 changes: 6 additions & 9 deletions environment.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
name: taranis
name: taranis_env
channels:
- conda-forge
- bioconda
- defaults
dependencies:
- conda-forge::python>=3.6
- conda-forge::biopython==1.72
- conda-forge::pandas==1.2.4
- conda-forge::openpyxl==3.0.7
- conda-forge::plotly==5.0.0
- conda-forge::numpy==1.20.3
- conda-forge::rich==13.7.0
- conda-forge::python-kaleido
- python=3.10
- conda-forge::poetry=1.7.1
- bioconda::prokka>=1.14
- bioconda::blast>=2.9
- bioconda::mash>=2
- bioconda::prodigal=2.6.3
- pip
- pip :
- -r requirements.txt
18 changes: 18 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
[tool.poetry]
name = "taranis"
version = "3.0.0"
description = "Tools for gene-by-gene allele calling analysis"
readme = "README.md"
authors = ["Sara Monzon <[email protected]>"]
license = "GNU-3.0"

[tool.poetry.dependencies]
python = "^3.10"

[tool.poetry.scripts]
taranis = "taranis.__main__:run_taranis"


[tool.setuptools.packages.find]
exclude = ["img", "virtualenv"]

5 changes: 4 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
biopython
rich
click
questionary
bio
scikit-learn
plotly
plotly
kaleido
38 changes: 0 additions & 38 deletions setup.py

This file was deleted.

2 changes: 1 addition & 1 deletion taranis/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import pkg_resources

__version__ = pkg_resources.get_distribution("taranis").version
__version__ = pkg_resources.get_distribution("taranis").version
Loading
Loading