Create #22
Open
Create #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
August 13, 2016 10:55
Create an easy installer for Ubuntu systems
Update to add information about tested and supported devices
| cd ../ | ||
| rm -Rf python-evic | ||
|
|
||
| echo Installation complete. Run \"sudo evic-usb upload /path/to/firmware.bin\" to install a new firmware. |
There was a problem hiding this comment.
Instead of recommending users to use sudo you should copy the udev rules to /etc/udev/rules.d/
Could this file be renamed to debian-install.sh
There was a problem hiding this comment.
Could the capitalization also be removed? using installers instead of Installers
|
Looks like you messed up something there. There's extra commits and merge conflicts. You should redo the changes in a clean branch. |
Create python-evic under /tmp instead of users home directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.