Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analyzer issues and update example for Dart 3 #845

Closed
wants to merge 2 commits into from

Conversation

Carapacik
Copy link
Contributor

@Carapacik Carapacik commented Jun 2, 2023

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Update to support newest Dart version(3.0.0)
Update example
Fix analyzer issues
Add ErrorListener to CacheNetworkImage widget

#843
#849
#850
#853
#854
#855
Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

Use this temp solution:

  cached_network_image:
    git:
      url: https://github.com/Carapacik/flutter_cached_network_image.git
      path: cached_network_image

@BirjuVachhani
Copy link

Any update on this? This is a blocker for me!

@Carapacik Carapacik changed the title Dart 3 support Dart 3 support to compatibility with http ^1.0.0 and file ^7.0.0 Jun 24, 2023
@gabielchong
Copy link

Any update on this? This is a blocker for me also.

@ibraheemalayan
Copy link

Having the same issue, are there any updates ?

@renefloor

@MarlonJD
Copy link

It should be approve ASAP!

@Carapacik
Copy link
Contributor Author

Carapacik commented Jul 7, 2023

@renefloor
I also added deprecation for Flutter 3.10(Dart 3) in this version:

`DecoderBufferCallback' is deprecated and shouldn't be used. 
Use ImageDecoderCallback with ImageProvider.loadImage instead. This feature was deprecated after v3.7.0-1.4.pre

@renefloor
Copy link
Contributor

Hi @Carapacik Thanks for the effort on the PR. However, this PR is really big, making it hard to review as it's unclear why some changes are made. Would it be possible to split this in smaller PR's with separate goals. As far as I know this package is fully compatible with Flutter 3.10 after we released your fixes in flutter_cache_manager.

Thanks for the warning that DecoderBufferCallback is now deprecated. I searched for the PR which did that and see it's about ResizePolicy. That's something I want to take a look into to see if we actually should support that with the image resizing in the cache package as well: flutter/flutter#121154

@Carapacik
Copy link
Contributor Author

@renefloor I can break this PR into 2 parts: analyzer and example update and deprecate DecoderBufferCallback

@Carapacik Carapacik marked this pull request as draft July 23, 2023 13:22
@Carapacik Carapacik closed this Jul 23, 2023
@Carapacik Carapacik force-pushed the dart-3 branch 2 times, most recently from 2740855 to d153049 Compare July 23, 2023 13:22
@renefloor
Copy link
Contributor

That would be great!

@Carapacik
Copy link
Contributor Author

Update example and specify types

@Carapacik Carapacik reopened this Jul 23, 2023
@Carapacik Carapacik marked this pull request as ready for review July 23, 2023 13:42
@Carapacik
Copy link
Contributor Author

I am ready to add another PR with other changes related to deprecated DecoderBufferCallback.

@Carapacik Carapacik changed the title Dart 3 support to compatibility with http ^1.0.0 and file ^7.0.0 Fix analyzer issues and update example Jul 23, 2023
@Carapacik Carapacik changed the title Fix analyzer issues and update example Fix analyzer issues and update example for Dart 3 Jul 23, 2023
@erdnj
Copy link

erdnj commented Jul 26, 2023

I think this pr should be merged immediately .

@Carapacik
Copy link
Contributor Author

@renefloor any news?

@Carapacik Carapacik closed this Sep 25, 2023
@Carapacik Carapacik deleted the dart-3 branch September 25, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants