DecoderBufferCallback is deprecated and DecoderCallback removed

[Carapacik]

✨ What kind of change does this PR introduce? (Bug fix)

Add loadImage instead loadBuffer deprecation

💥 Does this PR introduce a breaking change? Yes

Merge this PR after this
#845

📝 Links to relevant issues/docs

(Flutter Docs)
https://api.flutter.dev/flutter/painting/DecoderBufferCallback.html
https://api.flutter.dev/flutter/painting/ImageDecoderCallback.html

PR(Remove ImageProvider.load, DecoderCallback and PaintingBinding.instantiateImageCodec)
flutter/flutter#132679
flutter/flutter#133171

Checklist before submitting

• All projects build
• Follows style guide lines (code style guide)
• Relevant documentation was updated
• Rebased onto current develop

[gauravmehta13]

@Carapacik Can you please remove `DecoderBuffer' instead of deprecating it in another branch, since its removed on master

[renefloor]

Thanks for the thorough cleanup of all the code. Looks pretty good in general, but I also have to give it a good test to see if nothing breaks, because it is a big PR. I already added some comments and questions for potential improvements. I'll do my best to merge this PR quick. I've been on holiday for a couple of weeks, so I'm pickup up my slack.

[codecov]

Codecov Report

Patch coverage is 65.11% of modified lines.

Files Changed	Coverage
.../image_provider/cached_network_image_provider.dart	44.44%
...hed_network_image/lib/src/cached_image_widget.dart	50.00%
...e/lib/cached_network_image_platform_interface.dart	50.00%
...rk_image/lib/src/image_provider/_image_loader.dart	64.70%
...c/image_provider/multi_image_stream_completer.dart	100.00%

📢 Thoughts on this report? Let us know!.

[Carapacik]

@renefloor

[M1chlCZ]

I think there is a problem with octo_image dependency, which has blurhash_flutter dependency which still has that DecoderCallback

Here is the bug:

../../.pub-cache/hosted/pub.dev/flutter_blurhash-0.7.0/lib/src/blurhash_image.dart:32:48: Error: 'DecoderCallback' isn't a type.
  ImageStreamCompleter load(BlurHashImage key, DecoderCallback decode) => OneFrameImageStreamCompleter(_loadAsync(key))

And this is how I am using CachedNetworkImage in pubspec.yaml

  cached_network_image:
    git:
      url: https://github.com/Carapacik/flutter_cached_network_image.git
      path: cached_network_image

Flutter SDK 3.15 beta

[renefloor]

I think there is a problem with octo_image dependency, which has blurhash_flutter dependency which still has that DecoderCallback

Here is the bug:

../../.pub-cache/hosted/pub.dev/flutter_blurhash-0.7.0/lib/src/blurhash_image.dart:32:48: Error: 'DecoderCallback' isn't a type.
  ImageStreamCompleter load(BlurHashImage key, DecoderCallback decode) => OneFrameImageStreamCompleter(_loadAsync(key))

And this is how I am using CachedNetworkImage in pubspec.yaml

  cached_network_image:
    git:
      url: https://github.com/Carapacik/flutter_cached_network_image.git
      path: cached_network_image

Flutter SDK 3.15 beta

Thanks for the notice. I'll remove the dependency on blurhash from octo_image and write in the docs how to add it manually if you need it.

[renefloor]

Thanks a lot for all the effort!

[renefloor]

@M1chlCZ Baseflow/octo_image#30

[Carapacik]

@renefloor I think also need to update

flutter_cached_network_image/cached_network_image/pubspec.yaml

Line 20 in a0ce50a

octo_image: ^1.0.2

[renefloor]

Yes, I'll release octo_image first (probably today) and directly after cached_network_image with updated pubspec

[renefloor]

Released as 3.3.0: https://pub.dev/packages/cached_network_image/changelog