feat: Add support for error documents in the Agilent Gen5 adapter #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
joshua-benchling
commented
Oct 2, 2024
joshua-benchling
commented
- Added support for error documents
joshua-benchling
requested review from
a team,
slopez-b and
alejandro-salgado
as code owners
slopez-b
previously requested changes
Oct 2, 2024
src/allotropy/allotrope/schema_mappers/adm/plate_reader/rec/_2024/_06/plate_reader.py
Outdated
Show resolved
Hide resolved
tests/parsers/agilent_gen5/testdata/fluorescence/endpoint_single_plate_example.txt
Outdated
Show resolved
Hide resolved
slopez-b
reviewed
Oct 2, 2024
tests/parsers/agilent_gen5/testdata/absorbance/absorbance_error_document_example.txt
Outdated
Show resolved
Hide resolved
slopez-b
reviewed
Oct 2, 2024
tests/parsers/agilent_gen5/testdata/fluorescence/endpoint_single_plate_example.json
Outdated
Show resolved
Hide resolved
…ing them in the error documents
nathan-stender
requested changes
Oct 4, 2024
tests/parsers/agilent_gen5/testdata/absorbance/absorbance_error_document_example.txt
Show resolved
Hide resolved
nathan-stender
requested changes
Oct 4, 2024
nathan-stender
approved these changes
Oct 6, 2024
…ments_instead_of_nan
nathan-stender
deleted the
jherna/update_agilent_gen5_to_use_error_documents_instead_of_nan
branch
nathan-stender
added a commit
that referenced
this pull request
Oct 9, 2024
### Added - Revvity Kaleido - add v3.5 to supported software versions (#707) - Add new REC chema for solution analyzer 2024/09 (#706) - AppBio Quantstudio - support skipping wells that have no results in the raw data file, indicating an omitted well (#689) - AppBio Quantstudio - add "quantity" calculated data documents for non-STANDARD wells (#698) - Update adapters using 2024/06 Plate Reader schema to include ASM file identifier (#695) - NanoDrop 8000 & NanoDrop Eight - support alternative reporting format for absorbance measurements (#688) - Add support for error documents in the Agilent Gen5 adapter (#694) - Add the REC/2024/06 electrophoresis schema (#693) - Update Methodical Mind adapter to use REC schema (#692) - Update Methodical Mind to use the plate reader REC schema (#690) - Agilent Gen5 Image adapter, add support for no result sections file examples (#679) - ThermoSkanIt Adapter (#658) - Perkin Elmer Envision - Update adapter to use Plate Reader REC 2024/06 schema (#686) - BMG Mars - Update adapter to Plate Reader REC 2024/06 schema (#685) - Add REC/2024/06 spectrophotometry schema (#684) - Add Nanodrop Eight parser (#683) - Unchained Labs Lunatic - add additional metadata from header block (#680) ### Fixed - SoftMax Pro - raise error for unsupported Group data format (#696) - Agilent Gen5 - raise error when there are calculated data but no measurements in results (#691) - Beckman VI-Cell Blu - filter NaN values when reading cell counts (#687) - Update DataSeries to use float parsing utility when reading a float value, in order to better handle edge cases (#682) ### Changed - ThermoFisher Qubit Flex - refactor parser to use schema mapper design pattern (#699) - Change the way custom information is organized in schema mappers and ASM outputs to be consistent with future expectations of ASM (#673) - Rebrand nanodrop eight adapter to nanodrop 8000 (#652)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.