Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for error documents in the Agilent Gen5 adapter #694

Merged
merged 11 commits into from
Oct 6, 2024
Merged

feat: Add support for error documents in the Agilent Gen5 adapter #694

merged 11 commits into from
Oct 6, 2024

Commits on Oct 1, 2024

  1. Added test file

    @joshua-benchling
    joshua-benchling committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    20fb529 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. addded support for error documents

    @joshua-benchling
    joshua-benchling committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    aa9b2bd View commit details
    Browse the repository at this point in the history

  2. refactor code, make example file shorter

    @joshua-benchling
    joshua-benchling committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    cf11791 View commit details
    Browse the repository at this point in the history

  3. --ammend

    @joshua-benchling
    joshua-benchling committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f3d04c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. skipped not set values in the results

    @joshua-benchling
    joshua-benchling committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    923dfbe View commit details
    Browse the repository at this point in the history

  2. removed data documents that has a not valid value since we are report… 

    …ing them in the error documents
    @joshua-benchling
    joshua-benchling committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    c07fde9 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. solved pr comments

    @joshua-benchling
    joshua-benchling committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4271fe8 View commit details
    Browse the repository at this point in the history

  2. --ammend

    @joshua-benchling
    joshua-benchling committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0a0069c View commit details
    Browse the repository at this point in the history

  3. --ammend

    @joshua-benchling
    joshua-benchling committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    cd7ee6e View commit details
    Browse the repository at this point in the history

  4. --ammend

    @joshua-benchling
    joshua-benchling committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    376c6b5 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Merge branch 'main' into jherna/update_agilent_gen5_to_use_error_docu… 

    …ments_instead_of_nan
    @nathan-stender
    nathan-stender authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    f00c14c View commit details
    Browse the repository at this point in the history