fix HLS and DASH caption issues #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopefully a surgical change. downstream packages (hls.js and dash.js) are already drawn from the latest by default in mediaelement.js. based on past WIP by @jason-raitz. refs [DP-796](https://ucblib.atlassian.net/browse/DP-796). Co-authored-by: María A. Matienzo <[email protected]> Co-authored-by: Jason Raitz <[email protected]>
anarchivist
force-pushed
the
upgrade-mejs
branch
2 times, most recently
from
17751dd
to
77032d7
Compare
anarchivist
changed the title
|
This looks great! |
* switches from class-based "automatic start" of MediaElement.js instantiation to jQuery-based instantiation. this is necessary as we need to pass dash.js configuration options in to prevent it from rendering captions for us. * add `crossorigin="anonymous"` to `<video>` tag to allow a browser to load the webvtt file from wowza.lib.b.e.; otherwise this would be a cross-domain request * remove `default` from `<track>` tag to prevent captions from showing automatically.
* add new helper methods to grab the URI for a WebVTT file included in a HLS manifest * insert new <track/> tags specifically for HLS streams * inject HLS.js configuration options to hide captions it renders this will require setting the cupertinoVODCaptionsUseWebVTT property in all wowza collections to true. squashed refactors: * refactor new hls vtt private methods in track extensions * remove track tag for iOS as it is unnecessary
for iOS, it'll autodiscover the captions in the HLS stream when the viewer is in its standard full-screen mode. the track extensions code that grabs the HLS stream's WebVTT is thus unnecessary. this commits separates it out in case it becomes useful in the future.
|
did some more refactoring. the additional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crossorigin="anonymous"to<video>tag to allow a browser to load the webvtt file from wowza.lib.b.e.; otherwise this would be a cross-domain requestdefaultfrom<track>tag to prevent captions from showing automatically.cupertinoVODCaptionsUseWebVTTtotruefor all collections).add new helper methods to grab the URI for a WebVTT file included in a HLS manifest. adds a dependency on(removed in 07263a6)m3u8fixes DP-796; supersedes #3