Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HLS and DASH caption issues #4

Merged
merged 5 commits into from
Jul 8, 2024
Merged

fix HLS and DASH caption issues #4

merged 5 commits into from
Jul 8, 2024

Commits on Jun 27, 2024

  1. update mediaelement.js to latest release

    hopefully a surgical change. downstream packages (hls.js and dash.js)
    are already drawn from the latest by default in mediaelement.js. based
    on past WIP by @jason-raitz. refs [DP-796](https://ucblib.atlassian.net/browse/DP-796).
    
    Co-authored-by: María A. Matienzo <[email protected]>
    Co-authored-by: Jason Raitz <[email protected]>
    anarchivist and jason-raitz committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    61b9381 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    bcd6a25 View commit details
    Browse the repository at this point in the history
  2. change player initialization to fix DASH double captions

    * switches from class-based "automatic start" of MediaElement.js
    instantiation to jQuery-based instantiation. this is necessary
    as we need to pass dash.js configuration options in to prevent
    it from rendering captions for us.
    * add `crossorigin="anonymous"` to `<video>` tag to allow a
    browser to load the webvtt file from wowza.lib.b.e.; otherwise
    this would be a cross-domain request
    * remove `default` from `<track>` tag to prevent captions from
    showing automatically.
    anarchivist committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    f219b45 View commit details
    Browse the repository at this point in the history
  3. handle WebVTT captions in HLS manifests

    * add new helper methods to grab the URI for a WebVTT file included in a HLS manifest
    * insert new <track/> tags specifically for HLS streams
    * inject HLS.js configuration options to hide captions it renders
    
    this will require setting the cupertinoVODCaptionsUseWebVTT property in all
    wowza collections to true.
    
    squashed refactors:
    
    * refactor new hls vtt private methods in track extensions
    * remove track tag for iOS as it is unnecessary
    anarchivist committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e147e30 View commit details
    Browse the repository at this point in the history
  4. remove dead code in track extensions

    for iOS, it'll autodiscover the captions in the HLS stream when the viewer
    is in its standard full-screen mode. the track extensions code that grabs
    the HLS stream's WebVTT is thus unnecessary. this commits separates it out
    in case it becomes useful in the future.
    anarchivist committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    07263a6 View commit details
    Browse the repository at this point in the history