fix(statics): update ADA block explorer url #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CapnMigraine
previously approved these changes
Jun 23, 2023
alebusse
reviewed
Jun 23, 2023
| @@ -120,7 +120,7 @@ class Ada extends Mainnet implements AdaNetwork { | |||
| utxolibName = 'cardano'; | |||
| poolDeposit = 500000000; | |||
| stakeKeyDeposit = 2000000; | |||
| explorerUrl = 'https://explorer.cardano.org/en/'; | |||
| explorerUrl = 'https://explorer.cardano.org/en/transaction?id='; | |||
There was a problem hiding this comment.
This gonna is gonna be parsed by the UI as
https://explorer.cardano.org/en/transaction + txId + ?id=
There was a problem hiding this comment.
This should be fixed in that repo, not here as this is the base definition.
There was a problem hiding this comment.
Ah I see that now. Not sure how I'd work around this though aside from hard coding something in the UI
alebusse
approved these changes
Jun 23, 2023
mmcshinsky-bitgo
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CE-985