Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(statics): update ADA block explorer url #3690

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix(statics): update ADA block explorer url #3690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/statics/src/networks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class Ada extends Mainnet implements AdaNetwork {
utxolibName = 'cardano';
poolDeposit = 500000000;
stakeKeyDeposit = 2000000;
explorerUrl = 'https://explorer.cardano.org/en/';
explorerUrl = 'https://explorer.cardano.org/en/transaction?id=';
Copy link
Contributor

@alebusse alebusse Jun 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gonna is gonna be parsed by the UI as
https://explorer.cardano.org/en/transaction + txId + ?id=

https://github.com/BitGo/bitgo-microservices/blob/b51dc7e69d393f293ee3dbb14a7530488555a226/packages/client-app-dashboard/app/shared/api/utils.ts#L472

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed in that repo, not here as this is the base definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see that now. Not sure how I'd work around this though aside from hard coding something in the UI

coinsPerUtxoWord = 34482;
maxTransactionSize = 8000;
maxValueSize = 4000;
Expand Down