Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bitgo): add .prettierrc.yml #3698

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Commits on Jun 28, 2023

  1. chore(bitgo): add .prettierrc.yml

    The toplevel `.prettierrc.yml` has `requirePragma: true` which means it
    does not apply to most of the files in the bitgo module.
    
    I have seen multiple PRs with incidental formatting changes, probably because
    the IDE does not pick up the `.prettierrc.yml` in the bitgo module.
    
    This PR adds a `.prettierrc.yml` to the bitgo module but does do the
    reformatting yet. That will be in the next PR.
    
    To verify the changes, check out the PR and run these instructions
    
    ```
    git checkout BTC-0.prettier-bitgo
    git reset --hard HEAD~
    yarn prettier --write .
    git diff origin/BTC-0.prettier-bitgo # should be empty
    ```
    
    Issue: BTC-0
    OttoAllmendinger committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    e1bef96 View commit details
    Browse the repository at this point in the history
  2. chore(bitgo): apply prettier

    See previous commit with instructions on how to verify the changes in this
    commit
    
    Issue: BTC-0
    OttoAllmendinger committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    a867607 View commit details
    Browse the repository at this point in the history
  3. chore(bitgo): move ts-expect-error to the right place again

    Prettier placed it in the wrong line
    
    Issue: BTC-0
    OttoAllmendinger committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    e37ffb3 View commit details
    Browse the repository at this point in the history