chore(bitgo): add .prettierrc.yml #3698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toplevel `.prettierrc.yml` has `requirePragma: true` which means it does not apply to most of the files in the bitgo module. I have seen multiple PRs with incidental formatting changes, probably because the IDE does not pick up the `.prettierrc.yml` in the bitgo module. This PR adds a `.prettierrc.yml` to the bitgo module but does do the reformatting yet. That will be in the next PR. To verify the changes, check out the PR and run these instructions ``` git checkout BTC-0.prettier-bitgo git reset --hard HEAD~ yarn prettier --write . git diff origin/BTC-0.prettier-bitgo # should be empty ``` Issue: BTC-0
See previous commit with instructions on how to verify the changes in this commit Issue: BTC-0
OttoAllmendinger
force-pushed
the
BTC-0.prettier-bitgo
branch
from
2d8e697
to
a867607
Compare
Prettier placed it in the wrong line Issue: BTC-0
brandonblack
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toplevel
.prettierrc.ymlhasrequirePragma: truewhich means itdoes not apply to most of the files in the bitgo module.
I have seen multiple PRs with incidental formatting changes, probably
because the IDE does not pick up the
.prettierrc.ymlon the toplevel correctly and applies prettier to all files.To verify the changes, check out the PR and run these instructions
Issue: BTC-0