build(sdk-coin-xrp): update ripple libs #4947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hitansh-bitgo
force-pushed
the
WIN-3541
branch
4 times, most recently
from
aab1036
to
9a11ec3
Compare
hitansh-bitgo
changed the title
| @@ -91,7 +91,7 @@ describe('XRP:', function () { | |||
| txHex: | |||
| '{"TransactionType":"Payment","Account":"rBSpCz8PafXTJHppDcNnex7dYnbe3tSuFG","Destination":"rfjub8A4dpSD5nnszUFTsLprxu1W398jwc","DestinationTag":0,"Amount":"253481","Flags":2147483648,"LastLedgerSequence":1626225,"Fee":"45","Sequence":7}', | |||
| }); | |||
| unsignedExplanation.id.should.equal('CB36F366F1AC25FCDB38A19F17384ED3509D9B7F063520034597852FB10A1B45'); | |||
| unsignedExplanation.id.should.equal('37486621138DFB0C55FEF45FD275B565254464651A04CB02EE371F8C4A84D8CA'); | |||
There was a problem hiding this comment.
why are the values different ?
is this a breaking change ?
There was a problem hiding this comment.
ripple-lib 1.x only had the computeBinaryTransactionHash function that we used for both signed & unsigned txns, but xrpl 2.x has two separate functions to compute hashes for signed and unsigned transactions.
The hashSignedTx returns the same hash as computeBinaryTransactionHash since both the functions are same but hashTx(used for getting hash of unsigned Tx) uses a different HashPrefix than computeBinaryTransactionHash & hashSignedTx, hence the change in these hashes.
It most likely wouldn't break anything on WP but technically still is a breaking change so I've updated commit message
hitansh-bitgo
force-pushed
the
WIN-3541
branch
2 times, most recently
from
a98654e
to
58d17f7
Compare
alebusse
previously approved these changes
Oct 3, 2024
BREAKING CHANGE: explainTransaction for XRP transactions now computes a different transaction hash than previous versions. This is because xrpl 2.x uses different hash prefixes for computing signed and unsigned transaction hashes Ticket: WIN-3541
hitansh-bitgo
force-pushed
the
WIN-3541
branch
from
58d17f7
to
be7b887
Compare
DinshawKothari
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WIN-3541