perf: AsEphemeral once, early

BrackeysBot · Jul 21, 2023 · 2628f29 · 2628f29
1 parent 334f85b
commit 2628f29
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/SuggestionBot/Commands/SuggestCommand.cs b/SuggestionBot/Commands/SuggestCommand.cs
@@ -66,10 +66,11 @@ public async Task SuggestAsync(InteractionContext context)
         if (response != DiscordModalResponse.Success) return;
 
         var followUp = new DiscordFollowupMessageBuilder();
+        followUp.AsEphemeral();
+
         if (string.IsNullOrWhiteSpace(input.Value))
         {
             followUp.WithContent("No content provided. Suggestion cancelled.");
-            followUp.AsEphemeral();
             await context.FollowUpAsync(followUp).ConfigureAwait(false);
             return;
         }
@@ -79,13 +80,11 @@ public async Task SuggestAsync(InteractionContext context)
         if (message == null)
         {
             followUp.WithContent("Failed to post suggestion. If this issue persists, please contact ModMail.");
-            followUp.AsEphemeral();
             await context.FollowUpAsync(followUp).ConfigureAwait(false);
             return;
         }
 
         followUp.WithContent($"Your suggestion has been created and can be viewed here: {message.JumpLink}");
-        followUp.AsEphemeral();
         await context.FollowUpAsync(followUp).ConfigureAwait(false);
     }
 }