-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[sdkCore][Symbols]: ENG-7640 Set preview to true only if its not a symbol call #3805
fix[sdkCore][Symbols]: ENG-7640 Set preview to true only if its not a symbol call #3805
Conversation
🦋 Changeset detectedLatest commit: 79cccbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
View your CI Pipeline Execution ↗ for commit 79cccbb.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @anaghav2023
Last thing: it needs changeset. For that you can run yarn g:changeset
and add changesets (patch update) for both gen1 React (@builder.io/react
) and gen1 core (@builder.io/sdk
) SDKs
@sidmohanty11 I have made change only in the core still I need to add changesets for react as well? Then do I need to add it for other frameworks as well? |
@anaghav2023 as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Description
If we are using Symbol in any page. It reflects the unpublished changes. This is happening only on the content editor and not the actual website.
Before/After loom
https://www.loom.com/share/4ac7c396c70a4887a19b9f0eec295c63