Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[sdkCore][Symbols]: ENG-7640 Set preview to true only if its not a symbol call #3805

Merged
merged 5 commits into from
Jan 2, 2025
Merged

fix[sdkCore][Symbols]: ENG-7640 Set preview to true only if its not a symbol call #3805

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bed949d
set preview to true only if its not a symbol call
anaghav2023 Dec 30, 2024
3ac4797
checking the preview model
anaghav2023 Dec 30, 2024
20d48ff
Merge branch 'main' into ENG-7640-show-only-published-symbols-content
anaghav2023 Jan 2, 2025
d8cf89e
changeset
anaghav2023 Jan 2, 2025
79cccbb
improved commit message
anaghav2023 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/core/src/builder.class.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2630,16 +2630,19 @@ export class Builder {
}
}
}
if (this.preview) {
queryParams.preview = 'true';
}
const hasParams = Object.keys(queryParams).length > 0;

// TODO: option to force dev or qa api here
const host = this.host;

const keyNames = queue.map(item => encodeURIComponent(item.key!)).join(',');

const isSymbol = keyNames.includes('symbol');

if (this.preview && !isSymbol) {
anaghav2023 marked this conversation as resolved.
Show resolved Hide resolved
queryParams.preview = 'true';
}
const hasParams = Object.keys(queryParams).length > 0;

if (this.overrideParams) {
const params = omit(QueryString.parse(this.overrideParams), 'apiKey');
assign(queryParams, params);
Expand Down
Loading