generated from Byndyusoft/node-typescript-template
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lifecycle of producers and consumers #135
Merged
KillWolfVlad
merged 6 commits into
Byndyusoft:master
from
vglebovich-lmru:fix-consumers-close
Sep 4, 2024
Merged
fix: lifecycle of producers and consumers #135
KillWolfVlad
merged 6 commits into
Byndyusoft:master
from
vglebovich-lmru:fix-consumers-close
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@KillWolfVlad please take a look |
KillWolfVlad
previously approved these changes
Sep 2, 2024
vglebovich-lmru
changed the title
fix: use
fix: lifecycle of producers and consumers
Sep 2, 2024
onApplicationShutdown
to disconnect kafka producers
vglebovich-lmru
force-pushed
the
fix-consumers-close
branch
from
September 3, 2024 22:03
d6cc6af
to
7aeef8d
Compare
KillWolfVlad
requested changes
Sep 4, 2024
vglebovich-lmru
force-pushed
the
fix-consumers-close
branch
from
September 4, 2024 12:15
8526da3
to
726c1c1
Compare
KillWolfVlad
approved these changes
Sep 4, 2024
🎉 This PR is included in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
startAllMicroservices
andlisten
onApplicationShutdown
hook