Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lifecycle of producers and consumers #135

Merged
merged 6 commits into from
Sep 4, 2024
Merged

fix: lifecycle of producers and consumers #135

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
19b393a
fix: use `onApplicationShutdown` to disconnect kafka producers
vglebovich-lmru Sep 2, 2024
b4b890c
fix: use `onApplicationBootstrap` to start processing messages
vglebovich-lmru Sep 2, 2024
f626db8
Revert "fix: use `onApplicationBootstrap` to start processing messages"
vglebovich-lmru Sep 3, 2024
f468532
fix: throw an error when started listening before app is boostrapped
vglebovich-lmru Sep 3, 2024
7aeef8d
docs: notice about the right order of `startAllMicroservices` and `li…
vglebovich-lmru Sep 3, 2024
726c1c1
docs: fix README
vglebovich-lmru Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/producer/kafkaCoreProducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,21 @@
import {
Inject,
Injectable,
OnModuleDestroy,
OnApplicationShutdown,
OnModuleInit,
} from "@nestjs/common";
import { Producer } from "kafkajs";

import { ProducersMapToken } from "../consts";

@Injectable()
export class KafkaCoreProducer implements OnModuleInit, OnModuleDestroy {
export class KafkaCoreProducer implements OnModuleInit, OnApplicationShutdown {
public constructor(
@Inject(ProducersMapToken)
private readonly producersMap: Map<string, Producer>,
) {}

public async onModuleDestroy(): Promise<void> {
public async onApplicationShutdown(): Promise<void> {
await Promise.all(
[...this.producersMap.values()].map((x) => x.disconnect()),
);
Expand Down
Loading