Pull to refresh feature with UI changed #175

Rushour0 · 2022-11-09T09:32:49Z

Fixes #
Added a custom pull to refresh mentioned in the issue #91
I have also made UI changes to the auth screen mentioned in the issue #158

Describe the changes you have made in this PR -
Issue 91
Made a new TabControllerStorage since we cannot late initialise the tabcontroller, and thus cannot declare it out of the build method. Storing the tab index using this singleton implementation.
Added a new package custom_refresh_indicator to implement the pull to refresh feature with a custom icon

Issue 158
Made changes to the UI to make it better looking and user friendly.

Screenshots of the changes (If any) -
Issue 91

pull_to_refresh_feature.mp4

Issue 158

Rushour0 · 2022-11-09T09:37:27Z

@ItsAdityaKSingh you can check this commit, made a new branch for merging changes into it.
@nb9960 You can also check this if the need be.

ItsAdityaKSingh

Excellent work, @Rushour0! Overall looks good to me, though it partially closes issue #91. It still requires to be refreshed rather than automatically refreshed.

For the UI part, the buttons could be remade into a bit circular; it looks boxier than it should be on the hike and group screen. Also, for the auth screen, keeping the fields in the same card would still be preferred, honestly, though we can improvise. And the elevation also could be reduced.

lib/components/hike_button.dart

lib/views/auth_screen.dart

lib/views/group_screen.dart

Rushour0 · 2022-12-08T16:43:35Z

Excellent work, @Rushour0! Overall looks good to me, though it partially closes issue #91. It still requires to be refreshed rather than automatically refreshed.

For the UI part, the buttons could be remade into a bit circular; it looks boxier than it should be on the hike and group screen. Also, for the auth screen, keeping the fields in the same card would still be preferred, honestly, though we can improvise. And the elevation also could be reduced.

As for the constant refresh part, I feel it will consume more data to constantly keep refreshing the data. If people are going for a hike, then the connectivity and internet might be an issue. Considering that I put a pull-to-refresh instead of a stream like constant refresher

ItsAdityaKSingh · 2022-12-08T19:38:11Z

As for the constant refresh part, I feel it will consume more data to constantly keep refreshing the data. If people are going for a hike, then the connectivity and internet might be an issue. Considering that I put a pull-to-refresh instead of a stream like constant refresher

It should not always be refreshing, but as of right now, when the timer hits 0, the whole list needs to be manually refreshed to see that change. I meant to refresh the card when it becomes active. It could be automated to refresh only the card and not the whole list when it becomes active. Are you getting the idea?

Rushour0 · 2022-12-12T22:36:31Z

As for the constant refresh part, I feel it will consume more data to constantly keep refreshing the data. If people are going for a hike, then the connectivity and internet might be an issue. Considering that I put a pull-to-refresh instead of a stream like constant refresher

It should not always be refreshing, but as of right now, when the timer hits 0, the whole list needs to be manually refreshed to see that change. I meant to refresh the card when it becomes active. It could be automated to refresh only the card and not the whole list when it becomes active. Are you getting the idea?

Ahh alright 😌, I see what you wanted to do here. Okay, so essentially instead of complete list, just refresh the card according to its timer. If this is correct then I will work on this after my academic exams are over. Will get back to you in a few weeks with the new code.

ItsAdityaKSingh · 2022-12-13T06:32:04Z

Yup, you got it right! Along with this pull-to-refresh feature, there was this to be done! And indeed, you can work on it as soon as you get over the exams :)

Rushour0 · 2022-12-13T06:38:35Z

Yup, you got it right! Along with this pull-to-refresh feature, there was this to be done! And indeed, you can work on it as soon as you get over the exams :)

Alright then, I will finish the earlier changes mentioned in the code review and submit with the refreshing feature

ItsAdityaKSingh · 2023-01-04T17:31:29Z

Any updates @Rushour0?

Rushour0 · 2023-01-04T17:55:39Z

Any updates @Rushour0?

Was travelling a few days and was ill for some time. Just restarted work today. Will be done in 2-3 days.

Rushour0 · 2023-01-05T05:21:40Z

Any updates @Rushour0?

Hey I am facing a problem
I am not able to push any updates to the rushour0 branch of my repository.
It says error: failed to push some refs

Can you help me out?

@ItsAdityaKSingh I am actually dying here, because I spent 20 minutes making changes 2 hours trying to push a commit. Somehow my repository is corrupted(?) I actually do not know what to do here.

but to show you that change you suggested of rotating refresh icon

I have also made all other changes in the borders and all but I am not able to push anything.

Rushour0

fixed elevation, border rounding, reloading icon

Rushour0 · 2023-01-05T16:51:55Z

Any updates @Rushour0?

Hey I am facing a problem I am not able to push any updates to the rushour0 branch of my repository. It says error: failed to push some refs

Can you help me out?

@ItsAdityaKSingh I am actually dying here, because I spent 20 minutes making changes 2 hours trying to push a commit. Somehow my repository is corrupted(?) I actually do not know what to do here.

but to show you that change you suggested of rotating refresh icon

I have also made all other changes in the borders and all but I am not able to push anything.

Was still facing issue, uploaded the upgraded files manually, pulled and did a flutter test to verify

Rushour0 · 2023-01-08T06:14:32Z

@ItsAdityaKSingh can you review this again?

Rushour0 · 2023-01-18T06:06:54Z

@ItsAdityaKSingh hey can you check the latest changes in the PR

ItsAdityaKSingh · 2023-01-22T06:57:02Z

Hey @Rushour0! Sorry I was engaged with other stuff. Will review and get this resolved soon. Appreciate the patience :)
Some tests are failing, could you fix and commit them?

ItsAdityaKSingh · 2023-01-22T06:58:32Z

Also, the issue you were facing with the commit and pull, it's fixed right now, right?

Rushour0 · 2023-01-22T11:33:35Z

Also, the issue you were facing with the commit and pull, it's fixed right now, right?

No. I want to smash my repository. Idk what the issue is. It just keeps denying any remote push

Rushour0

Removed that single unnecessary variable
@ItsAdityaKSingh can you put it for checking if it fails tests

Rushour0 · 2023-02-12T12:54:27Z

Hey @ItsAdityaKSingh can you check if this can be merged?

Rushour0 · 2023-03-10T14:08:27Z

Opening a new PR for the same
This one has gotten a bit messy and unattended for a while now

Rushour0 and others added 4 commits October 28, 2022 22:32

refresh on pull implemented for group screen tabs

ed5521e

fixed the issue

9a227fb

button redo

be54d8d

Merge branch 'CCExtractor:main' into rushour0

33ff636

ItsAdityaKSingh requested changes Dec 8, 2022

View reviewed changes

ItsAdityaKSingh mentioned this pull request Dec 8, 2022

TextFormField separator removal #170

Open

ItsAdityaKSingh mentioned this pull request Dec 8, 2022

Auth Screen UI, centering buttons #144

Closed

Rushour0 commented Jan 5, 2023

View reviewed changes

Rushour0 added 3 commits January 5, 2023 22:07

Add files via upload

e520f61

elevation changed + better reload icon code

62a7228

reloading icon rotating + hike button border fixed

2ae0541

Rushour0 requested a review from ItsAdityaKSingh January 5, 2023 17:02

removed unnecessary "screensize" variable

604642c

Rushour0 commented Jan 22, 2023

View reviewed changes

Merge branch 'main' into rushour0

d3a9a22

Rushour0 closed this Mar 10, 2023

Rushour0 deleted the rushour0 branch March 10, 2023 14:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pull to refresh feature with UI changed #175

Pull to refresh feature with UI changed #175

Rushour0 commented Nov 9, 2022

Rushour0 commented Nov 9, 2022 •

edited

Loading

ItsAdityaKSingh left a comment •

edited

Loading

Rushour0 commented Dec 8, 2022

ItsAdityaKSingh commented Dec 8, 2022

Rushour0 commented Dec 12, 2022

ItsAdityaKSingh commented Dec 13, 2022

Rushour0 commented Dec 13, 2022

ItsAdityaKSingh commented Jan 4, 2023

Rushour0 commented Jan 4, 2023

Rushour0 commented Jan 5, 2023 •

edited

Loading

Rushour0 left a comment

Rushour0 commented Jan 5, 2023 •

edited

Loading

Rushour0 commented Jan 8, 2023

Rushour0 commented Jan 18, 2023

ItsAdityaKSingh commented Jan 22, 2023 •

edited

Loading

ItsAdityaKSingh commented Jan 22, 2023

Rushour0 commented Jan 22, 2023 •

edited

Loading

Rushour0 left a comment •

edited

Loading

Rushour0 commented Feb 12, 2023

Rushour0 commented Mar 10, 2023

Pull to refresh feature with UI changed #175

Pull to refresh feature with UI changed #175

Conversation

Rushour0 commented Nov 9, 2022

Rushour0 commented Nov 9, 2022 • edited Loading

ItsAdityaKSingh left a comment • edited Loading

Choose a reason for hiding this comment

Rushour0 commented Dec 8, 2022

ItsAdityaKSingh commented Dec 8, 2022

Rushour0 commented Dec 12, 2022

ItsAdityaKSingh commented Dec 13, 2022

Rushour0 commented Dec 13, 2022

ItsAdityaKSingh commented Jan 4, 2023

Rushour0 commented Jan 4, 2023

Rushour0 commented Jan 5, 2023 • edited Loading

Rushour0 left a comment

Choose a reason for hiding this comment

Rushour0 commented Jan 5, 2023 • edited Loading

Rushour0 commented Jan 8, 2023

Rushour0 commented Jan 18, 2023

ItsAdityaKSingh commented Jan 22, 2023 • edited Loading

ItsAdityaKSingh commented Jan 22, 2023

Rushour0 commented Jan 22, 2023 • edited Loading

Rushour0 left a comment • edited Loading

Choose a reason for hiding this comment

Rushour0 commented Feb 12, 2023

Rushour0 commented Mar 10, 2023

Rushour0 commented Nov 9, 2022 •

edited

Loading

ItsAdityaKSingh left a comment •

edited

Loading

Rushour0 commented Jan 5, 2023 •

edited

Loading

Rushour0 commented Jan 5, 2023 •

edited

Loading

ItsAdityaKSingh commented Jan 22, 2023 •

edited

Loading

Rushour0 commented Jan 22, 2023 •

edited

Loading

Rushour0 left a comment •

edited

Loading