Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dan / 6338: Follow up css fix #6880

Merged
merged 2 commits into from
Oct 30, 2023
Merged

dan / 6338: Follow up css fix #6880

merged 2 commits into from
Oct 30, 2023

Conversation

DanielSass
Copy link
Collaborator

@DanielSass DanielSass commented Oct 30, 2023 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Improve css

Additional Information

  • deploying to dev7

Testing

  • Look at it. Does it look pretty?

Screenshots / Demos

  • For large changes, please pair with a designer to ensure changes are as intended

@DanielSass DanielSass temporarily deployed to dev7 October 30, 2023 15:20 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

johanna-skylight
johanna-skylight approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@johanna-skylight johanna-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks 💯

emyl3
emyl3 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎨 Looks good on dev7!

@DanielSass DanielSass marked this pull request as ready for review October 30, 2023 17:55
@DanielSass DanielSass added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 72b9e5b Oct 30, 2023
33 checks passed
@DanielSass DanielSass deleted the dan/6338-follow-up-css-fix branch October 30, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanna-skylight johanna-skylight johanna-skylight approved these changes

@emyl3 emyl3 emyl3 approved these changes

@nathancrtr nathancrtr Awaiting requested review from nathancrtr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielSass @emyl3 @johanna-skylight