Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dan / 6338: Follow up css fix #6880

Merged
merged 2 commits into from
Oct 30, 2023
Merged

dan / 6338: Follow up css fix #6880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b124f1
updating css to suck less
DanielSass Oct 30, 2023
664ee57
updating snapshot for css update
DanielSass Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions frontend/src/app/Settings/Users/ManageUsers.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,6 @@
margin-block-start: 1em;
margin-block-end: 1em;
}

.users-secondary-nav {
max-height: 44rem;
overflow-y: scroll;
}
}

.users-sidenav-item:hover {
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/Settings/Users/UsersSideNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const UsersSideNav: React.FC<Props> = ({
<div className="display-block users-sidenav">
<h2 className="users-sidenav-header">Users</h2>
<nav
className="prime-secondary-nav users-secondary-nav"
className="prime-secondary-nav maxh-tablet-lg overflow-y-scroll"
aria-label="Tertiary navigation"
>
<div
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/Settings/Users/__snapshots__/ManageUsersContainer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ exports[`ManageUsersContainer loads the component and displays users successfull
</h2>
<nav
aria-label="Tertiary navigation"
class="prime-secondary-nav users-secondary-nav"
class="prime-secondary-nav maxh-tablet-lg overflow-y-scroll"
>
<div
aria-owns="user-tab-3a4a221d-a8ca-42b3-aa03-37b93266025b user-tab-1029653e-24d9-428e-83b0-468319948902 user-tab-17656bad-08b6-4fd4-bb9a-ccac54e5ea0a user-tab-60bb9e3a-fe8a-4b81-b894-b01649c95e70 user-tab-0d3fa224-3d56-4382-b89c-9d8e415e59b3 user-tab-17656bad-07b6-4fd4-bb9a-ccbc54e5ea0a"
Expand Down
Loading