Results page and PXP support for Hepatitis C #8249
Conversation
mpbrown
force-pushed
the
mike/7437-results-page-hep-c
branch
from
b92a987 to
59ebd9d
Compare
|
LGTM! Ty for all your work. |
There was a problem hiding this comment.
hahah I thought I was losing my mind seeing all the same changes that I thought I already reviewed in the previous PR. 😵 Didn't realize this was not up to date with main 😅 so reviewed the diff locally and codewise looks good!
Testing on dev4 also worked as expected! Nice work on this, Mike! 🎉
frontend/src/lang/en.ts
Outdated
| h1: "For Hepatitis-C:", | ||
| positive: { | ||
| p0: "If you have a positive result, you will need a follow-up test to confirm your results. The organization that provided your test should be able to answer questions and provide referrals for follow-up testing.", | ||
| p1: "<0>Visit the CDC website to learn more about a positive Hepatitis-C result.</0> (cdc.gov/hepatitis-c/testing/index.html#cdc_testing_results-testing-results).", |
There was a problem hiding this comment.
I know this is so minor but I don't think we should have a period between the link text and the URL in parentheses, so that we can match the copy for the other diseases. maybe this can be fixed in #8255
| const mockDiseaseEnabledFlag = ( | ||
| diseaseName: string, | ||
| skipLowercase: boolean = false | ||
| ) => | ||
| jest | ||
| .spyOn(flaggedMock, "useFeature") | ||
| .mockImplementation((flagName: string) => { | ||
| // to handle casing of Hepatitis-C as hepatitisC | ||
| if (skipLowercase) { | ||
| return flagName === `${diseaseName}Enabled`; | ||
| } | ||
| return flagName === `${diseaseName.toLowerCase()}Enabled`; | ||
| }); |
There was a problem hiding this comment.
this is a nit but I don't think this method needs the added complexity of a skipLowercase parameter. I think we can just call it with the disease names in lower case
mpbrown
dismissed stale reviews from mehansen, bobbywells52, and emyl3
via
1c219c1
mpbrown
force-pushed
the
mike/7437-results-page-hep-c
branch
from
aa2ac27 to
1c219c1
Compare
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
FRONTEND PULL REQUEST
Related Issue
Changes Proposed
Additional Information
Testing
Screenshots / Demos
Hepatitis-C already available as a selectable condition on Results page
Hepatitis-C already available as a condition in the Download Results spreadsheet
Hepatitis-C on Print Details modal
Spanish translations for Hepatitis-C on Print Details modal
Hepatitis-C and AOE responses on View Details modal
Hepatitis-C result on the PXP View Result
Spanish translations for Hepatitis-C result on the PXP View Result
Negative Hepatitis-C result with result guidance still shown
