Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Hepatitis-C to Hepatitis C #8255

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Rename Hepatitis-C to Hepatitis C #8255

merged 2 commits into from
Nov 5, 2024

Conversation

mpbrown
Copy link
Collaborator

@mpbrown mpbrown commented Oct 31, 2024 •
edited
Loading

BACKEND AND FRONTEND PULL REQUEST

Changes Proposed

  • Changes the naming of Hepatitis-C to Hepatitis C (without a dash) to match CDC usage.

Additional Information

Testing

  • Deployed on dev4, some screenshots below of the rename

image
image

@mpbrown mpbrown changed the title Mike/rename hepatitis c Rename Hepatitis-C to Hepatitis C Oct 31, 2024
@mpbrown mpbrown mentioned this pull request Oct 31, 2024
Merged
@mpbrown mpbrown force-pushed the mike/rename-hepatitis-c branch from 08d88ec to c311ef1 Compare November 5, 2024 14:58
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mpbrown mpbrown marked this pull request as ready for review November 5, 2024 16:02
bobbywells52
bobbywells52 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! To avoid having to go back and redo the name of any disease with a dash in the future should we add guidance on copy around said diseases to the adding a disease guide?

emyl3
emyl3 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this up! 🧹

@mpbrown
Copy link
Collaborator Author

mpbrown commented Nov 5, 2024

LGTM! To avoid having to go back and redo the name of any disease with a dash in the future should we add guidance on copy around said diseases to the adding a disease guide?

@bobbywells52 I could add a small note that reminds us to be consistent with how CDC refers to the disease

@mpbrown mpbrown added this pull request to the merge queue Nov 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024
@mpbrown mpbrown added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 8e4aa72 Nov 5, 2024
42 checks passed
@mpbrown mpbrown deleted the mike/rename-hepatitis-c branch November 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbywells52 bobbywells52 bobbywells52 approved these changes

@emyl3 emyl3 emyl3 approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@DanielSass DanielSass Awaiting requested review from DanielSass

@DavidMcClatchey DavidMcClatchey Awaiting requested review from DavidMcClatchey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpbrown @emyl3 @bobbywells52