Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medaka updates for new 10.4.1 grid chemistry #12

Closed
wants to merge 31 commits into from

Conversation

arianna-smith
Copy link
Contributor

@arianna-smith arianna-smith commented Feb 17, 2024

Overview

Update Medaka task for new grid 10.4.1 chemistry.

Updates

Task Section Previous Updated
Demultiplex barcode kit EXP-NBD196 SQK-NBD114-96
Demultiplex task container version latest 6.4.6
Medaka model r941_min_high_g360 r1041_e82_400bps_hac_v4.2.0
Medaka container quay.io/staphb/artic-ncov2019:1.3.0 quay.io/staphb/artic/1.2.4-1.11.1

New task - exit_wdl

  • Input: string exit_reason (declared in the script, no input changes needed)
  • This task will automatically error out when called by utilizing the runtime return_codes attribute.
  • We could make this a task we import and use it to exit in other workflows for other reasons if needed.

Known issue

Problem

See issue created in artic-network.

Solution

Check the size of the fasta file generated. If under 30B, then fail the sample. A new task, exit_wdl, was written to accomplish this.

Upstream/downstream changes needed

None :)

Changes needed on user end

None :)

arianna-smith and others added 30 commits December 27, 2023 18:48
WDL doesn't recognize git, so use wget to download primer schemes under commit e6ddb7c (committed 6/14/23). Can't use tag to download since there hasn't been a new release or tag in 3 years.
See if it helps with empty fasta issues
This reverts commit f9bd15a.
1. Check if the consensus file is generated
2. If so, check if < 30B (empty ~16B, succeeded ~29KB)
3. If so, call medaka with strict
4. Select first for medaka outputs
Remove trim_barcodes parameter and variable
Hardcode barcode kit, remove variable
Remove rerun medaka task with --strict parameter, adjust downstream variable declarations
Remove debugging vcf files output
@sam-baird
Copy link
Contributor

These changes have been merged into the develop branch and will be merged to main in the v2.2.0 PR (#17)

@sam-baird sam-baird closed this Mar 20, 2024
@arianna-smith arianna-smith deleted the wip-medaka-test branch June 27, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants