importer: Rename Output->Related Document and link doc for errored rows #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakshamarora1
force-pushed
the
link_pid_for_importer_errors
branch
from
99e0c62
to
fc3e6dc
Compare
jrcastro2
reviewed
Mar 1, 2024
| @@ -35,7 +35,7 @@ export class ImportedTable extends React.Component { | |||
| Action | |||
| </Table.HeaderCell> | |||
| <Table.HeaderCell collapsing rowSpan="3"> | |||
| Output document | |||
| Related document | |||
There was a problem hiding this comment.
Comment: If this change was discussed with the library then it's good to me. Otherwise be aware that this will affect to correclty processed records as well.
I would check with them before, if not already done.
There was a problem hiding this comment.
This was discussed! 😄
kpsherva
reviewed
Mar 4, 2024
kpsherva
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #820