Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

importer: Rename Output->Related Document and link doc for errored rows #855

Merged
merged 2 commits into from
Apr 4, 2024
Merged

importer: Rename Output->Related Document and link doc for errored rows #855

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc3e6dc
importer: Rename Output->Related Document and link doc for errored rows
sakshamarora1 Feb 21, 2024
c041c36
importer: Set output_pid in raw_json in handler
sakshamarora1 Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cds_ils/importer/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,11 @@ def importer_exception_handler(
exc, log_id, record_recid, json_data=None, *args, **kwargs
):
"""Handle importer exception."""
report = {"raw_json": json_data}
if hasattr(exc, "record_id"):
report["output_pid"] = exc.record_id
sakshamarora1 marked this conversation as resolved.
Show resolved Hide resolved
ImportRecordLog.create_failure(
log_id, record_recid, str(exc.description), report={"raw_json": json_data}
log_id, record_recid, str(exc.description), report=report
)


Expand Down
2 changes: 1 addition & 1 deletion ui/src/importer/importerTaskDetails/ImporterTaskDetailsComponents/ImportedTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class ImportedTable extends React.Component {
Action
</Table.HeaderCell>
<Table.HeaderCell collapsing rowSpan="3">
Output document
Related document
Copy link
Contributor

@jrcastro2 jrcastro2 Mar 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment: If this change was discussed with the library then it's good to me. Otherwise be aware that this will affect to correclty processed records as well.
I would check with them before, if not already done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was discussed! 😄

</Table.HeaderCell>
<Table.HeaderCell collapsing colSpan="4">
Dependent records
Expand Down
Loading