Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KNoT Type IDs: acceleration and angular velocity #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add KNoT Type IDs: acceleration and angular velocity #7

wants to merge 2 commits into from

Conversation

luigiluz
Copy link
Contributor

@luigiluz luigiluz commented Jan 8, 2020 •
edited
Loading

Add two new KNoT Type IDs:

  • Acceleration | Unit: m/s²
  • Angular Velocity | Units: °/s and rad/s

@luigiluz luigiluz requested review from alla3 and vitbaq January 8, 2020 13:04
@luigiluz luigiluz self-assigned this Jan 8, 2020
@luigiluz luigiluz changed the title Add KNoT Type ID acceleration Add KNoT Type IDs: acceleration and angular velocity Jan 8, 2020
@luigiluz luigiluz force-pushed the knot-type-acceleration branch 2 times, most recently from 1288fda to 823adf5 Compare January 13, 2020 18:01
@luigiluz luigiluz requested a review from tgfb January 20, 2020 17:58
pauloserrafh
pauloserrafh reviewed Jan 22, 2020
View reviewed changes
src/knot_types.h Outdated Show resolved Hide resolved
pauloserrafh
pauloserrafh reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@pauloserrafh pauloserrafh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick on 823adf commit message: KNOT should be KNoT

pauloserrafh
pauloserrafh reviewed Jan 22, 2020
View reviewed changes
src/knot_protocol.c Outdated Show resolved Hide resolved
@vitbaq vitbaq self-requested a review January 22, 2020 14:39
tgfb
tgfb requested changes Jan 22, 2020
View reviewed changes
Copy link
Collaborator

@tgfb tgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review revision comments and perform requested changes.

@luigiluz
Add KNoT Type ID acceleration
cdaf25c 
Add KNoT Type ID acceleration using m/s² as unit.
@luigiluz
Add KNoT Type ID angular velocity
d19fb92 
Add angular velocity KNOT Type ID with units rad/seg and deg/seg.
@luigiluz luigiluz force-pushed the knot-type-acceleration branch from 823adf5 to d19fb92 Compare January 22, 2020 17:14
@pauloserrafh pauloserrafh self-requested a review January 22, 2020 17:31
@luigiluz luigiluz mentioned this pull request Jan 31, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgfb tgfb tgfb requested changes

@pauloserrafh pauloserrafh pauloserrafh approved these changes

@alla3 alla3 Awaiting requested review from alla3

@vitbaq vitbaq Awaiting requested review from vitbaq

Assignees

@luigiluz luigiluz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luigiluz @tgfb @pauloserrafh @vitbaq