Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging unstable to develop #484

Merged
merged 123 commits into from
Jan 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
123 commits
Select commit Hold shift + click to select a range
cef220c
Major refactor in preparation for arbitrary grid implementation
kubagalecki Oct 31, 2023
aa91ec6
Fixing solid tests makefile
kubagalecki Nov 6, 2023
2bc275b
Fixing sign conversion and no return value warnings
kubagalecki Nov 6, 2023
4beb133
fixed ignored return value and string format warnings
kubagalecki Nov 6, 2023
3792f02
fixed passing std::string to vararg function
kubagalecki Nov 6, 2023
0745a96
fixed missing parens
kubagalecki Nov 6, 2023
0985da4
fixed const correctness in Lattice::Get_X
kubagalecki Nov 6, 2023
1eff4d3
fixed Python support
kubagalecki Nov 6, 2023
cb9d434
fixed mkdir_p utility
kubagalecki Nov 6, 2023
73cd3c9
Updated "compare.cpp" from features/conversion branch
kubagalecki Nov 6, 2023
df56ea6
revert to old compare.cpp
kubagalecki Nov 6, 2023
59800c6
Adding asserts on the piece regions in compare
llaniewski Nov 7, 2023
79d83fa
Merge pull request #1 from llaniewski/patch-2
kubagalecki Nov 7, 2023
74c48e3
Fixed region passed to VTK writer
kubagalecki Nov 7, 2023
5fe9440
Fix solver outliving CUDA and MPI + cosmetic issues
kubagalecki Nov 7, 2023
4198789
Merge pull request #460 from kubagalecki/develop
llaniewski Nov 8, 2023
f7a6986
Merge remote-tracking branch 'origin/develop' into unstable
llaniewski Nov 13, 2023
85ab8ef
Merge remote-tracking branch 'origin/develop' into unstable
llaniewski Nov 13, 2023
37157c1
Read arbitrary lattice from file + small utilities
kubagalecki Nov 8, 2023
ce36872
added utility for exporting to arbitrary grid (.cxn) format
kubagalecki Nov 14, 2023
ae451d2
toArb is now called before lattice initialization (alleviates memory …
kubagalecki Nov 15, 2023
eec8568
Added arbitrary lattice reading and partitioning
kubagalecki Nov 20, 2023
444ca57
Fixed R bug in determining unique offset directions
kubagalecki Nov 20, 2023
155747b
Added static assertion on stencil symmetry
kubagalecki Nov 20, 2023
0080478
Model information now exposed via static constexpr objects (RTemplate…
kubagalecki Nov 21, 2023
eef7fbd
Local node permutation for arb lattice
kubagalecki Nov 22, 2023
3025671
Merge remote-tracking branch 'origin/develop' into unstable
llaniewski Nov 22, 2023
360fabd
Device memory allocation for arbitrary lattice
kubagalecki Nov 23, 2023
b411c6e
Arbitrary lattice LIDs are now unsigned
kubagalecki Nov 23, 2023
429d588
Dynamic offset index lookup
kubagalecki Nov 23, 2023
b452ce3
Groups/zones in ArbLattice done (host + device)
kubagalecki Nov 24, 2023
131caf4
minor refactor of node types for ArbLattice
kubagalecki Nov 26, 2023
b7304d0
Added ArbLattice handler, refactore initialization
kubagalecki Nov 27, 2023
0279679
Arbitrary lattice snaps now correctly stored as storage_t
kubagalecki Nov 27, 2023
ccd1ce8
Fixed missing declaration in types.h
kubagalecki Nov 27, 2023
464362e
Added braces around sub-object initialization to satisfy llvm warning
kubagalecki Nov 27, 2023
cb5d7a3
Renamed Lattice to CartLattice
kubagalecki Nov 29, 2023
89a6bad
cross.h disabled in Solid tests
kubagalecki Nov 29, 2023
2f4b0df
Temporarily disabled ArbLatticeX files
kubagalecki Nov 29, 2023
8d13f03
fixed config.h outside of include guard in cross.h
kubagalecki Nov 29, 2023
efffeb1
R-based dispatch to actions now private for CartLattice
kubagalecki Nov 29, 2023
2a41acb
RunAction in CartLattice marked as final
kubagalecki Nov 29, 2023
02a5bb8
Preliminary working version of computations on arbitrary lattices
kubagalecki Nov 30, 2023
8ab41bc
Added default for Z arg in ArbLatticeAccess::load_X to maintain corre…
kubagalecki Dec 1, 2023
50aac70
Fixed dynamic lookup init for ArbLattice
kubagalecki Dec 1, 2023
a0576af
Explicitly deleted copy semantics for ArbLattice to satisfy llvm warning
kubagalecki Dec 1, 2023
f4954d9
Explicitly deleted copy semantics for ArbLattice to satisfy llvm warning
kubagalecki Dec 1, 2023
3f4ea35
fixed snap type in ArbLatticeContainer
kubagalecki Dec 1, 2023
f577e11
Cuts for arb lattice now compile and error out at runtime
kubagalecki Dec 1, 2023
c47e64e
nvcc bug(?) workaround
kubagalecki Dec 1, 2023
4aa0b6c
Reverting CPU kernel param types to uint3
kubagalecki Dec 4, 2023
1b0849a
Fixed ob1 bug in stencil size computation
kubagalecki Dec 4, 2023
9dfeaa5
VTU geometry added to ArbLattice
kubagalecki Dec 4, 2023
1e25111
Added GetQuantity executor to arb lattice
kubagalecki Dec 4, 2023
58a2d03
Added quantity getters for arb lattice
kubagalecki Dec 4, 2023
4431700
vtu export working, WIP: debugging arb. kernels
kubagalecki Dec 7, 2023
f21e4b9
debugged kernels
kubagalecki Dec 7, 2023
9419dd4
Debugged globals
kubagalecki Dec 8, 2023
38acb75
WIP: MPI for arb lattice
kubagalecki Dec 8, 2023
73f3b96
Correcting passing vector by value in initCommManager
llaniewski Dec 8, 2023
55db602
Fixed lifetime bug in arb MPI init
kubagalecki Dec 8, 2023
51e9762
Some mods for paranoid
llaniewski Dec 9, 2023
a005fc2
Adding debug vtu
llaniewski Dec 10, 2023
4ad1306
Adding debug dump files for ArbLattice
llaniewski Dec 11, 2023
851b6de
Correcting the inverse of permutation in computeLocalPermutation
llaniewski Dec 11, 2023
953157e
Merge branch 'arbitrary-grid-develop' into arbitrary-grid-patch-1
llaniewski Dec 11, 2023
1ec9531
Adding missing specialisation of mpi type
llaniewski Dec 11, 2023
bfaccee
Merge pull request #2 from llaniewski/arbitrary-grid-patch-1
kubagalecki Dec 11, 2023
4dbf028
Merge pull request #3 from kubagalecki/arbitrary-grid-develop
kubagalecki Dec 11, 2023
89d58be
Some more debug information
llaniewski Dec 12, 2023
95ec223
Even more debug information
llaniewski Dec 12, 2023
9de78b1
Removed graph row sort
llaniewski Dec 12, 2023
2008e5c
Merge pull request #462 from kubagalecki/arbitrary-grid
llaniewski Dec 13, 2023
7a6f0e3
corrections for paranoid
llaniewski Dec 13, 2023
c355056
Merge pull request #467 from llaniewski/arbitrary-grid-debug
llaniewski Dec 16, 2023
5ea56cd
Merge remote-tracking branch 'origin/develop' into unstable
llaniewski Dec 16, 2023
cd5be39
Merge remote-tracking branch 'origin/develop' into unstable
llaniewski Dec 19, 2023
c6fd807
Clearing RT from Solver.h
llaniewski Dec 19, 2023
d7652ff
Removing remnants of travis-ci
llaniewski Dec 19, 2023
08d5758
Removing RT from Solver log
llaniewski Dec 19, 2023
3ff5d9c
Moving sides to array
llaniewski Dec 19, 2023
2031d80
Removing RT from Solver
llaniewski Dec 19, 2023
b6b1823
Removing RT from Geometry
llaniewski Dec 19, 2023
2a8a6ee
Removing RT from Global.cpp
llaniewski Dec 19, 2023
3d740ed
Removing RT from Global.h
llaniewski Dec 19, 2023
29252ce
First moves towards working RunR
llaniewski Dec 19, 2023
bcad0ef
+ initial fix to remove nan. todo-new field for solid, remove edge ra…
TravisMitchell Dec 20, 2023
8a8a277
+ add nan flag for cart grid as well for consistent behaviour
TravisMitchell Dec 20, 2023
a1be45a
+ comment print statements
TravisMitchell Dec 20, 2023
66e3be3
Streamlined intefraces
llaniewski Dec 20, 2023
4f505d0
Adding formatting of R code to tools/format.sh
llaniewski Dec 20, 2023
f05a11b
+ adjust calc grad phi for efficiency, maintainability, and consistency
TravisMitchell Dec 20, 2023
909fe65
Merge pull request #472 from llaniewski/feature/formatR
llaniewski Dec 20, 2023
0689a48
Merge pull request #471 from TravisMitchell/arb-fix/d2q9_pf_velocity
llaniewski Dec 20, 2023
25318ee
Merge remote-tracking branch 'cfdgo/unstable' into unstable-refactor
llaniewski Dec 20, 2023
bcbef29
Adding missing headers
llaniewski Dec 20, 2023
dcdaf48
Correcting tests/solid
llaniewski Dec 20, 2023
72fc48c
+ fix loop as we need to include first weight for denom
TravisMitchell Dec 21, 2023
1e67f65
+ fix paranoid compile for potential uninitiation
TravisMitchell Dec 21, 2023
b38b8dd
Merge pull request #474 from TravisMitchell/arb-fix/d2q9_pf_velocity
llaniewski Dec 21, 2023
0921777
Minor refactor of arb debug facilities
kubagalecki Dec 28, 2023
e2e599d
Allow the user to initialize NVFLAGS
kubagalecki Dec 28, 2023
c61a63c
toArb optimizations
kubagalecki Dec 28, 2023
4e5a626
Implemented failcheck handler for arbitrary grid
kubagalecki Dec 29, 2023
6bf10c4
Strategy selection for computing the local permutation
kubagalecki Dec 29, 2023
68eade2
Default permutation strategy changed to "coords"
kubagalecki Dec 31, 2023
660cb83
BIN handler for arb lattice
kubagalecki Dec 31, 2023
5d7635b
Added TXT handler for arb lattice
kubagalecki Dec 31, 2023
e02f071
Added facilities for saving/loading the solution to/from binary files…
kubagalecki Dec 31, 2023
6016957
Merge remote-tracking branch 'kubagalecki/arbitrary-grid' into unstab…
llaniewski Jan 3, 2024
a32c7ab
Merge remote-tracking branch 'origin/develop' into unstable
llaniewski Jan 3, 2024
53c2c68
Merge remote-tracking branch 'cfdgo/unstable' into unstable-refactor
llaniewski Jan 3, 2024
c6b2c9e
Fixing comparison in RunR
llaniewski Jan 3, 2024
2691cbb
Adding missing override keywords
llaniewski Jan 3, 2024
d90e9e7
Correcting getPar (and related) functions)
llaniewski Jan 3, 2024
b73a714
Correcting error in getCoords
llaniewski Jan 3, 2024
a1bf8e4
Correcting another error in getCoords
llaniewski Jan 3, 2024
72ac9c7
Correcting error in nodetype assign in RunR
llaniewski Jan 3, 2024
b01c27f
Merge remote-tracking branch 'origin/develop' into unstable
llaniewski Jan 5, 2024
9e8cf4f
Merge remote-tracking branch 'cfdgo/unstable' into unstable-refactor
llaniewski Jan 5, 2024
e9f5266
Adding default densities to ArbLatticeAccess
llaniewski Jan 5, 2024
eed8630
Fixing hdf5 for cartesian lattice
llaniewski Jan 8, 2024
6faf88e
Merge pull request #481 from llaniewski/unstable-refactor
llaniewski Jan 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101,748 changes: 101,748 additions & 0 deletions example/data/karman_ARB_P00.cxn

Large diffs are not rendered by default.

15 changes: 7 additions & 8 deletions models/multiphase/d2q9_pf_velocity/Dynamics.R
Original file line number Diff line number Diff line change
Expand Up @@ -86,20 +86,20 @@ if (Options$RT) {
AddStage("BaseInit" , "Init_distributions" , save=Fields$group %in% c("g","h","Vel"))

# iteration
AddStage("BaseIter" , "calcHydroIter" , save=Fields$group %in% c("g","h","Vel","nw") , load=DensityAll$group %in% c("g","h","Vel","nw")) # TODO: is nw needed here?
AddStage("BaseIter" , "calcHydroIter" , save=Fields$group %in% c("g","h","Vel","nw") , load=DensityAll$group %in% c("PF","g","h","Vel","nw")) # TODO: is nw needed here?
AddStage("PhaseIter" , "calcPhaseFIter" , save=Fields$group %in% c("PF") , load=DensityAll$group %in% c("g","h","Vel","nw"))
AddStage("WallIter" , "calcWallPhaseIter" , save=Fields$group %in% c("PF") , load=DensityAll$group %in% c("nw"))
AddStage("WallIter" , "calcWallPhaseIter" , save=Fields$group %in% c("PF") , load=DensityAll$group %in% c("nw","PF")) # Purposefully read/write of PF for boundary. complex geom may force RACE condition.
}

AddAction("Iteration", c("BaseIter", "PhaseIter","WallIter"))
AddAction("Init" , c("PhaseInit","WallInit", "WallIter","BaseInit"))

# Outputs:
AddQuantity(name="Rho", unit="kg/m3")
AddQuantity(name="PhaseField",unit="1")
AddQuantity(name="U", unit="m/s",vector=T)
AddQuantity(name="NormalizedPressure", unit="Pa")
AddQuantity(name="Pressure", unit="Pa")
AddQuantity(name="Rho", unit="kg/m3")
AddQuantity(name="PhaseField", unit="1")
AddQuantity(name="U", unit="m/s",vector=T)
AddQuantity(name="NormalizedPressure", unit="1")
AddQuantity(name="Pressure", unit="Pa")
AddQuantity(name="Normal", unit="1", vector=T)

# Initialisation States
Expand Down Expand Up @@ -209,5 +209,4 @@ if (Options$Outflow) {
}
AddNodeType(name="Solid", group="BOUNDARY")
AddNodeType(name="Wall", group="BOUNDARY")
AddNodeType(name="BGK", group="COLLISION")
AddNodeType(name="MRT", group="COLLISION")
Loading