-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slow matchfile parsing due to duplicate lines check #306
Comments
I wrote the duplicate line check but that does not sound reasonable. Are you sure the issue is from the duplicate line checking? |
Yes I'm sure the issue stems from that part. Without this check, the file takes ~27secs to load (as it is quite large). With the checks, it takes >3.5hrs. I noticed this mainly because I was working on different branches, one of which had not yet been merged into
Using this approach the same file takes ~25secs to load. Currently this is on my local branch only - it's not yet pushed as I would like to first address some raised issues that also relate to match file importing. |
Parsing match files takes longer than in previous versions due to the duplicate lines check in
importmatch.py
. The attached test file (converted to .txt) takes > 3hrs to load.beethoven_op026_mv3.txt
The text was updated successfully, but these errors were encountered: