Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster Matchifile Parsing and Checks. #307

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Faster Matchifile Parsing and Checks. #307

merged 2 commits into from
Sep 20, 2023

Conversation

manoskary
Copy link
Member

This PR presents a solution for faster checking of empty and duplicate lines in matchfiles using numpy arrays and numpy vectorization.

@manoskary
Addresses #306
76381eb 
This PR presents a solution for faster checking of empty and duplicate lines in matchfiles using numpy arrays and numpy vectorization.
@manoskary manoskary requested a review from huispaty August 10, 2023 16:16
@manoskary manoskary self-assigned this Aug 10, 2023
@manoskary manoskary linked an issue Aug 10, 2023 that may be closed by this pull request
slow matchfile parsing due to duplicate lines check #306
Closed
@manoskary manoskary requested review from fosfrancesco and removed request for huispaty August 21, 2023 10:00
@huispaty huispaty requested review from huispaty and removed request for fosfrancesco August 29, 2023 09:35
huispaty
huispaty previously requested changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@huispaty huispaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach you've presented is efficient but could be simplified. If you're open to it, I would suggest considering the alternative one-liner I proposed earlier.

partitura/io/importmatch.py Show resolved Hide resolved
@huispaty huispaty requested review from huispaty and CarlosCancino-Chacon and removed request for huispaty September 4, 2023 13:23
@manoskary manoskary requested review from huispaty and removed request for huispaty September 7, 2023 14:03
CarlosCancino-Chacon
CarlosCancino-Chacon requested changes Sep 20, 2023
View reviewed changes
partitura/io/importmatch.py Outdated Show resolved Hide resolved
partitura/io/importmatch.py Show resolved Hide resolved
partitura/io/importmatch.py Outdated Show resolved Hide resolved
@manoskary
Removed warnings.
c7b4b36 
corrections requested by reviewers.
@manoskary manoskary dismissed huispaty’s stale review September 20, 2023 13:39

Comments are already addressed, the reviewer removed themselves from the PR.

@CarlosCancino-Chacon CarlosCancino-Chacon merged commit 3fa85f7 into develop Sep 20, 2023
3 checks passed
@CarlosCancino-Chacon CarlosCancino-Chacon deleted the fast_matchfile_parsing branch September 20, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huispaty huispaty huispaty left review comments

@CarlosCancino-Chacon CarlosCancino-Chacon CarlosCancino-Chacon approved these changes

Assignees

@manoskary manoskary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slow matchfile parsing due to duplicate lines check
3 participants
@manoskary @CarlosCancino-Chacon @huispaty