Improve discovery scalabiltiy #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConorGriffin37
force-pushed
the
feature/conor/discoveryscalability
branch
from
beecce7
to
2968359
Compare
ConorGriffin37
force-pushed
the
feature/conor/discoveryscalability
branch
from
2968359
to
6f607d2
Compare
| "strconv" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestMain(m *testing.M) { | ||
| Log = logger.New("discoveryTest", "discoveryTest", "/dev/null") | ||
| Log.SetLogLevel(logger.ERROR) | ||
| Pools = make(map[string]*Pool) | ||
| StateDirectoryPath = path.Join(os.TempDir(), "server_state_bench") |
There was a problem hiding this comment.
Would be nicer if we stored all /tmp tests in some more defined way, so for example all tests would be in /tmp/paranoid-tests/$component
There was a problem hiding this comment.
Would definitely be better. You should make an issue, I doubt we will end up fixing it before the end of the sprint though.
There was a problem hiding this comment.
I made a issue for it: #401
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add locking and unlocking to avoid threading issues. Locking both for all pools when adding a pool per pool in general.
Add and remove operations are now O(SizeOfPool), not O(TotalNodes).