[refactor] pull1Port: use partition from Data.List
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acl-cqc
commented
Dec 3, 2024
brat/Brat/Checker/Helpers.hs
Outdated
| pull1Port p = do | ||
| available <- get | ||
| case partition ((== p) . toPort . fst) available of | ||
| ([], _) -> lift $ err $ BadPortPull $ "Port not found: " ++ p ++ " in " ++ showFn available |
There was a problem hiding this comment.
Not quite a refactor (1/2): changed fail to BadPortPull as the latter is otherwise unused
acl-cqc
commented
Dec 3, 2024
brat/Brat/Checker/Helpers.hs
Outdated
| case partition ((== p) . toPort . fst) available of | ||
| ([], _) -> lift $ err $ BadPortPull $ "Port not found: " ++ p ++ " in " ++ showFn available | ||
| ([found], remaining) -> put remaining >> pure found | ||
| (_, _) -> lift $ err $ AmbiguousPortPull p (showFn available) |
There was a problem hiding this comment.
Not quite a refactor (2/2): we used to pass to showFn here only the suffix of available beginning with the first match
croyzor
reviewed
Dec 4, 2024
acl-cqc
force-pushed
the
acl/refactor_portpull2
branch
from
eb2795d to
e2983c7
Compare
|
Ok, fair enough, I think the main improvement here is the use of |
acl-cqc
changed the title
partition from Data.List
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite a refactor - change
failto aBadPortPullerror, and slight change to the error message for AmbiguousPortPull (now includes preceding but irrelevant/non-pulled ports)