Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBVEC emulator improvement #408

Merged
merged 2 commits into from
Oct 10, 2024
Merged

HBVEC emulator improvement #408

merged 2 commits into from
Oct 10, 2024

Conversation

lou-a
Copy link
Collaborator

@lou-a lou-a commented Oct 10, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Added an alias for rain snow fraction to match other emulators.

Does this PR introduce a breaking change?

This minor change should not lead to any breaking changes and it should be covered by emulator tests already included in the repo.

Other information:

lou-a and others added 2 commits October 10, 2024 13:46
Added an alias for rain snow fraction to match other emulators.
@coveralls
Copy link

Coverage Status

coverage: 81.343%. remained the same
when pulling 61310e3 on hbvec-improvement
into 86d6306 on master.

@lou-a lou-a requested a review from huard October 10, 2024 18:16
@lou-a lou-a merged commit 5a21e70 into master Oct 10, 2024
16 checks passed
@lou-a lou-a deleted the hbvec-improvement branch October 10, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants