Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mujoco sim upgrades #126

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Mujoco sim upgrades #126

merged 8 commits into from
Nov 25, 2024

Conversation

Zolkin1
Copy link
Collaborator

@Zolkin1 Zolkin1 commented Nov 7, 2024

Updated some features in the Mujoco simulation:

  • Removed the need to specify nu in the yaml, instead we now read that from the Mujoco model. This was annoying because if you forgot to update the yaml it was hard to figure out what the issue was.
  • Removed the need to specify the sim timestep in the yaml, instead we now read that from the Mujoco model. In the future we can add back the option to overwrite the Mujoco time step with what the user puts in the yaml, but for now that seems unnecessary.

Updated the docs to be more accurate.

@Zolkin1 Zolkin1 linked an issue Nov 7, 2024 that may be closed by this pull request
@Zolkin1 Zolkin1 mentioned this pull request Nov 7, 2024
18 tasks
@Zolkin1 Zolkin1 marked this pull request as ready for review November 7, 2024 22:43
@Zolkin1 Zolkin1 requested a review from alberthli November 7, 2024 22:43
Copy link
Contributor

@alberthli alberthli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Zolkin1 Zolkin1 merged commit 7698047 into main Nov 25, 2024
1 check passed
@Zolkin1 Zolkin1 deleted the mujoco-sim-upgrades branch November 25, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the timestep in the config yaml for the sim
2 participants