feat(playground): added more playground examples #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhagmajer
reviewed
Oct 28, 2020
Comment on lines
+117
to
+123
| return { | ||
| data: dataSet['date'], | ||
| dailyconfirmed: dataSet['dailyconfirmed'], | ||
| dailydeceased: dataSet['dailydeceased'], | ||
| dailyrecovered: dataSet['dailyrecovered'] | ||
| } | ||
| }) |
There was a problem hiding this comment.
let's fix the indentation
There was a problem hiding this comment.
Also return is not needed here
There was a problem hiding this comment.
This mapping is essentially picking keys from objects. Shall we change key names to make this a little more exciting?
mhagmajer
reviewed
Oct 28, 2020
| @@ -12,4 +13,32 @@ export const customResources: Resources = { | |||
| return "Hi, this is AskQL server! It's " + new Date().toString(); | |||
| }, | |||
| }), | |||
| statewise: resource({ | |||
There was a problem hiding this comment.
Let's make this custom resource name more specific
mhagmajer
suggested changes
Oct 28, 2020
There was a problem hiding this comment.
Thanks for adding more examples @YonatanKra.
All of those are currently using fetch and map maybe we can use add filter to some of them to make them more interesting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #181