-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#580): a basic implementation of js function calling from askcript #590
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
); | ||
}); | ||
it(`should wrap wrapMe2 js method nad return arg`, async function () { | ||
const expectedResult = 'arg'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe using a different string than 'arg' would be better, so that it's not the same as the variable name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@mhagmajer , do you have any specific comments on this PR? @pkarw , I added a few minor comments if you had time, but feel free to merge it without addressing them. |
With this feature developers get a new helper/factory method which can be used for passing JS modules and functions to AskScript without the need of manually warping them with resources.
Usage:
You can easily wrap a whole module like
lodash
by just simply: