Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance tile skirts light occlusion #11460

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+227 −52
Open

Enhance tile skirts light occlusion #11460

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0f7c1bc
increase tile skirts size and adding bottom plane to tile for better …
kalosma Aug 7, 2023
7431534
fixed minor issue
kalosma Aug 9, 2023
349fb5e
Merge branch 'main' into skirts
kalosma Mar 29, 2024
8f5c0ea
restored default behaviour if long skirts are not enabled
kalosma Apr 3, 2024
ada4f70
added extendedSkirts flag to CesiumTerrainProvider to enable extended…
kalosma Apr 4, 2024
3a3a7ad
Merge branch 'main' into skirts
kalosma Apr 4, 2024
2342e83
updated changes file
kalosma Apr 5, 2024
5771a80
fixed typo
kalosma Apr 5, 2024
ac6a15c
Merge branch 'main' into skirts
kalosma Apr 8, 2024
a067089
Merge branch 'main' into skirts
kalosma Apr 23, 2024
9c8dd15
Merge branch 'main' into skirts
kalosma May 15, 2024
b3a7c12
fixed test failure
kalosma May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
updated changes file
@kalosma
kalosma committed Apr 5, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 2342e836b117622ca9963f39abad20a58c5db563
1 change: 1 addition & 0 deletions CHANGES.md
View file
Original file line number Diff line number Diff line change
@@ -15,6 +15,7 @@
- Implemented sharper rendering and lighting on voxels with CYLINDER and ELLIPSOID shape. [#11875](https://github.com/CesiumGS/cesium/pull/11875)
- Implemented vertical exaggeration for voxels with BOX shape. [#11887](https://github.com/CesiumGS/cesium/pull/11887)
- Added the `Check` object of validators to the public api and types. [#11901](https://github.com/CesiumGS/cesium/pull/11901)
- Added ab optional property 'extendedSkirts' to `CesiumTerrainProvider`to enable extended skirts on tiles, improving light occlusion when shadows are enabled. [#11459][https://github.com/cesiumgs/cesium/issues/11459]

##### Fixes :wrench: