Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance tile skirts light occlusion #11460

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Prev Previous commit
fixed test failure
kalosma committed May 15, 2024
commit b3a7c124643eb9330092a80a2e43bac909b681fd
3 changes: 2 additions & 1 deletion packages/engine/Source/Core/QuantizedMeshTerrainData.js
Original file line number Diff line number Diff line change
@@ -522,6 +522,7 @@ QuantizedMeshTerrainData.prototype.upsample = function (
? this._northSkirtHeight
: shortestSkirt * 0.5;
const credits = this._credits;
const extendedSkirts = this._extendedSkirts;

return Promise.resolve(upsamplePromise).then(function (result) {
const quantizedVertices = new Uint16Array(result.vertices);
@@ -556,7 +557,7 @@ QuantizedMeshTerrainData.prototype.upsample = function (
childTileMask: 0,
credits: credits,
createdByUpsampling: true,
extendedSkirts: this._extendedSkirts,
extendedSkirts: extendedSkirts,
});
});
};