Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client(consensus/grandpa): implement grandpa justification logic #3454

Merged
merged 34 commits into from
Nov 6, 2023
Merged

client(consensus/grandpa): implement grandpa justification logic #3454

merged 34 commits into from
Nov 6, 2023

Conversation

jimjbrettj
Copy link
Contributor

@jimjbrettj jimjbrettj commented Aug 24, 2023 •
edited
Loading

Changes

  • Add justification logic to grandpa using generics
  • Write unit tests for justification logic
  • Added justification logic to grandpa aux db
  • made finalityGrandpa Message value public for encoding/setting

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Primary Reviewer

@EclesioMeloJunior

EclesioMeloJunior
EclesioMeloJunior previously requested changes Aug 30, 2023
View reviewed changes
client/consensus/grandpa/aux_schema.go Outdated Show resolved Hide resolved
client/consensus/grandpa/aux_schema.go Outdated Show resolved Hide resolved
client/consensus/grandpa/aux_schema.go Outdated Show resolved Hide resolved
client/consensus/grandpa/aux_schema.go Outdated Show resolved Hide resolved
client/consensus/grandpa/interfaces.go Outdated Show resolved Hide resolved
client/consensus/grandpa/interfaces.go Outdated Show resolved Hide resolved
client/consensus/grandpa/lib.go Outdated Show resolved Hide resolved
client/consensus/grandpa/lib.go Outdated Show resolved Hide resolved
pkg/finality-grandpa/lib.go Show resolved Hide resolved
@jimjbrettj jimjbrettj force-pushed the jimmy/grandpaJustification branch from d829e7c to a9b5775 Compare September 6, 2023 20:59
@jimjbrettj jimjbrettj force-pushed the jimmy/grandpaJustification branch from a9b5775 to 757de79 Compare September 11, 2023 21:34
@jimjbrettj jimjbrettj mentioned this pull request Sep 13, 2023
Merged
timwu20
timwu20 reviewed Sep 18, 2023
View reviewed changes
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/aux_schema.go Outdated Show resolved Hide resolved
client/consensus/grandpa/aux_schema.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
@jimjbrettj jimjbrettj force-pushed the jimmy/grandpaJustification branch from 757de79 to e26e8dc Compare October 2, 2023 19:11
@jimjbrettj jimjbrettj force-pushed the jimmy/auxDbInterface branch from 3d3fc50 to ae01109 Compare October 2, 2023 19:42
@jimjbrettj jimjbrettj force-pushed the jimmy/grandpaJustification branch from e26e8dc to be3fd96 Compare October 2, 2023 19:47
@jimjbrettj jimjbrettj force-pushed the jimmy/auxDbInterface branch from ae01109 to 24e07e3 Compare October 3, 2023 21:45
@jimjbrettj jimjbrettj force-pushed the jimmy/grandpaJustification branch from 672ad57 to 9961953 Compare October 3, 2023 21:56
@jimjbrettj jimjbrettj force-pushed the jimmy/auxDbInterface branch from 20bef8a to db5219f Compare October 10, 2023 17:49
@jimjbrettj jimjbrettj force-pushed the jimmy/grandpaJustification branch from 9961953 to 02ace76 Compare October 17, 2023 19:29
Base automatically changed from jimmy/auxDbInterface to feat/grandpa October 18, 2023 18:25
@jimjbrettj jimjbrettj requested a review from timwu20 October 19, 2023 21:06
timwu20
timwu20 requested changes Oct 23, 2023
View reviewed changes
client/consensus/grandpa/aux_schema.go Outdated Show resolved Hide resolved
client/consensus/grandpa/interfaces.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
@jimjbrettj jimjbrettj requested a review from timwu20 October 25, 2023 20:29
@jimjbrettj jimjbrettj requested a review from timwu20 October 26, 2023 19:40
timwu20
timwu20 approved these changes Nov 1, 2023
View reviewed changes
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Show resolved Hide resolved
@jimjbrettj jimjbrettj dismissed EclesioMeloJunior’s stale review November 6, 2023 21:07

All conversations were resolved

@jimjbrettj jimjbrettj merged commit 3396fa8 into feat/grandpa Nov 6, 2023
22 checks passed
@jimjbrettj jimjbrettj deleted the jimmy/grandpaJustification branch November 6, 2023 21:35
timwu20 added a commit that referenced this pull request Dec 5, 2023
@jimjbrettj @timwu20
client(consensus/grandpa): implement grandpa justification logic (#3454)
87df026 
Co-authored-by: Timothy Wu <[email protected]>
timwu20 added a commit that referenced this pull request Apr 18, 2024
@jimjbrettj @timwu20
client(consensus/grandpa): implement grandpa justification logic (#3454)
226459f 
Co-authored-by: Timothy Wu <[email protected]>
timwu20 added a commit that referenced this pull request Apr 19, 2024
@jimjbrettj @timwu20
client(consensus/grandpa): implement grandpa justification logic (#3454)
97bb70c 
Co-authored-by: Timothy Wu <[email protected]>
timwu20 added a commit that referenced this pull request Apr 19, 2024
@jimjbrettj @timwu20
client(consensus/grandpa): implement grandpa justification logic (#3454)
7a4f5a7 
Co-authored-by: Timothy Wu <[email protected]>
EclesioMeloJunior pushed a commit that referenced this pull request Jul 9, 2024
@jimjbrettj @timwu20 @EclesioMeloJunior
client(consensus/grandpa): implement grandpa justification logic (#3454)
82437d3 
Co-authored-by: Timothy Wu <[email protected]>
timwu20 added a commit that referenced this pull request Oct 11, 2024
@jimjbrettj @timwu20
client(consensus/grandpa): implement grandpa justification logic (#3454)
60f62fd 
Co-authored-by: Timothy Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timwu20 timwu20 timwu20 approved these changes

@edwardmack edwardmack Awaiting requested review from edwardmack

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

@dimartiro dimartiro Awaiting requested review from dimartiro

@kanishkatn kanishkatn Awaiting requested review from kanishkatn

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior

Assignees

@EclesioMeloJunior EclesioMeloJunior

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimjbrettj @timwu20 @EclesioMeloJunior