feat(prospective-parachains): implements GetBackableCandidates
#4374
Conversation
…elDDHM/gossamer into feature/add_get_backable_candidates
|
Hey @DanielDDHM! Thank you for your contribution! Please can you assign corresponding issue to your self, this will helps us track progress. Thank you! |
Hello @P1sar I will be assign and focus on this task again asap, at the moment I am focusing on performing this one #4390 anything else, i will let you know, thanks. |
DanielDDHM
requested review from
EclesioMeloJunior,
jimjbrettj and
timwu20
as code owners
DanielDDHM
changed the title
|
@haikoschol @EclesioMeloJunior @P1sar a small review please. |
DanielDDHM
changed the title
GetBackableCandidates
| } | ||
| } | ||
|
|
||
| func TestGetBackableCandidates(t *testing.T) { |
There was a problem hiding this comment.
Please add more tests to cover the various cases that result in an empty response.
You probably want to use a generated mock for that. Here is an example for how to do that.
There was a problem hiding this comment.
@haikoschol i trying to refactor these tests and i will let you know
Changes
implements GetBackableCandidates
Tests
Unit Tests: Core logic is tested in isolation using testify for assertions
go test -tags integration github.com/ChainSafe/gossamerIssues
GetBackableCandidatessignal #4310