Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prospective-parachains): implements
GetBackableCandidates
#4374base: eclesio/fragment-chain-impl
Are you sure you want to change the base?
feat(prospective-parachains): implements
GetBackableCandidates
#4374Changes from 11 commits
6555735
138c004
2be6501
61f8ee6
dfca73c
06c3f4d
3d6f093
31bdd9d
3e65830
b0a69e0
f85bff0
83f38a2
111ba1c
ae2e7f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 141 in dot/parachain/prospective-parachains/prospective-parachains.go
GitHub Actions / linting
Check failure on line 141 in dot/parachain/prospective-parachains/prospective-parachains.go
GitHub Actions / linting
Check failure on line 141 in dot/parachain/prospective-parachains/prospective-parachains.go
GitHub Actions / integration-tests (github.com/ChainSafe/gossamer/dot)
Check failure on line 141 in dot/parachain/prospective-parachains/prospective-parachains.go
GitHub Actions / zombienet-tests
Check failure on line 141 in dot/parachain/prospective-parachains/prospective-parachains.go
GitHub Actions / unit-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add more tests to cover the various cases that result in an empty response.
You probably want to use a generated mock for that. Here is an example for how to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haikoschol i trying to refactor these tests and i will let you know