Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] folder module: update endpoint now requires which update option you want #389

Closed
lgetwan opened this issue Jul 28, 2023 · 2 comments · Fixed by #408 or #405
Closed

[BUG] folder module: update endpoint now requires which update option you want #389

lgetwan opened this issue Jul 28, 2023 · 2 comments · Fixed by #408 or #405
Assignees
Labels
bug Something isn't working module:folder This affects the folder module release:3.0.0 Affects the mentioned release.

Comments

@lgetwan
Copy link
Contributor

lgetwan commented Jul 28, 2023

Describe the bug

After https://checkmk.com/werk/15888, it's no longer possible to provide more than one of the parameters attributes, remove_attributes and update_attributes
The ansible module still alows this, though.

Component Name
folder

Ansible Version
any

Checkmk Version and Edition
any

Collection Version
2.3.0

Current behavior
The folder module allows the user tries to provide more than one of these parameters and then runs into an ugly error message

Expected behavior
The folder module should write a friendly error message if the user tries to provide more than one of these parameters.
The documentation should also tell to use one of them, only.

@lgetwan lgetwan added bug Something isn't working module:folder This affects the folder module release:2.3.0 Affects the mentioned release. labels Jul 28, 2023
@lgetwan lgetwan self-assigned this Jul 28, 2023
@robin-checkmk robin-checkmk added release:4.1.0 Affects the mentioned release. and removed release:2.3.0 Affects the mentioned release. labels Jul 31, 2023
@msekania
Copy link
Contributor

msekania commented Aug 1, 2023

@lgetwan

What's about warning message in the case of employed Check MK v < 2.2.0p7 (2.3.0b1), and error for Check MK v2.2.0p7 (eventually 2.3.0b1) and higher.
Like: simultaneously using more than one from parameters attributes, remove_attributes, and update_attributes will not be (is not) supported in Check MK starting from v2.2.0p7 (eventually 2.3.0b1) and higher?
If huge refactoring of the folder module s not planned I can prepare the pull request with all the necessary changes.

Second question: Is API for host module is also affected, since this features are similar for folder and host modules?

@lgetwan
Copy link
Contributor Author

lgetwan commented Aug 2, 2023

@msekania
That sounds great! There's no refactoring for the folder module in our pipeline, you can go for it.
Our developers are aware that the host_config endpoint has a similar issue, but they don't have it in their backlog, yet.

@robin-checkmk robin-checkmk added release:2.5.0 and removed release:4.1.0 Affects the mentioned release. labels Aug 7, 2023
This was linked to pull requests Aug 9, 2023
@robin-checkmk robin-checkmk added release:3.0.0 Affects the mentioned release. and removed release:2.5.0 labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module:folder This affects the folder module release:3.0.0 Affects the mentioned release.
Projects
None yet
3 participants