Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module folder for future checkmk releases #408

Conversation

msekania
Copy link
Contributor

@msekania msekania commented Aug 8, 2023

Fixes issue #389

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently all three options attributes, remove_attributes, and update_attributes can be used simultaneously, which is no longer supported by API for Check MK >= v2.2.0p7

Issue Number: #389

What is the new behavior?

  • issue a warning message if more then one option from attributes, remove_attributes, and update_attributes is used simultaneously for Check MK < v2.2.0p7
  • fail with error message if more then one option from attributes, remove_attributes, and update_attributes is used simultaneously for Check MK >= v2.2.0p7

Other information

@msekania msekania requested a review from lgetwan as a code owner August 8, 2023 16:16
@github-actions github-actions bot added the module:folder This affects the folder module label Aug 8, 2023
@robin-checkmk robin-checkmk self-assigned this Aug 9, 2023
@robin-checkmk
Copy link
Member

As review was already done in #404 I will merge this PR directly.

Thanks for your contribution @msekania! 🙏

@robin-checkmk robin-checkmk mentioned this pull request Aug 8, 2023
7 tasks
@robin-checkmk robin-checkmk merged commit 2c1fc05 into Checkmk:devel Aug 9, 2023
27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
@robin-checkmk robin-checkmk added the release:3.0.0 Affects the mentioned release. label Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module:folder This affects the folder module release:3.0.0 Affects the mentioned release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] folder module: update endpoint now requires which update option you want
2 participants