Update circles-core dependency and use new pathfinder service

[llunaCreixent]

By default the pathfinder type is server. However, we can get same behavior as before by keeping the value to cli.
Note that in case of using the type server, the parameter hops will be ignored, otherwise (with type cli) the maxTransfers parameter will be ignored. Therefore, we should review the logic using the hops to optimize the transfer steps response (#597).

The retry loops are now conditioned to the pathfinder type. The retry logic for token.transfer and token.findTransitiveTransfer are not needed anymore.

Closes #631

Add an exception when txHash is null during transfer.

Closes #589

[netlify]

✅ Deploy Preview for relaxed-snyder-612ce8 ready!

Name	Link
🔨 Latest commit	e4483b8
🔍 Latest deploy log	https://app.netlify.com/sites/relaxed-snyder-612ce8/deploys/64467304e1934c0008439ca6
😎 Deploy Preview	https://deploy-preview-630--relaxed-snyder-612ce8.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for preview-review-circles-garden ready!

Name	Link
🔨 Latest commit	e4483b8
🔍 Latest deploy log	https://app.netlify.com/sites/preview-review-circles-garden/deploys/64467304b5cc430008d6c9ff
😎 Deploy Preview	https://deploy-preview-630.review.circles.garden/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for preview-testing-circles-garden ready!

Name	Link
🔨 Latest commit	e4483b8
🔍 Latest deploy log	https://app.netlify.com/sites/preview-testing-circles-garden/deploys/64467304190d5a0008a720c2
😎 Deploy Preview	https://deploy-preview-630--preview-testing-circles-garden.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[louilinn]

Is this a draft PR until circles core 4.0.0 is ready?

[llunaCreixent]

Is this a draft PR until circles core 4.0.0 is ready?

Correct

[llunaCreixent]

@louilinn I removed the loops when using the pathfinder service, maybe we have to review it after our conversation today

[llunaCreixent]

I'm going to deploy this branch in preview-testing @mikozet @louilinn

[juanenrisley]

For me, everything is okay. Let's see what @louilinn has to say about it! 💪🏿

[mikozet]

I connected an issue to zenhub as it states in Development tab in github

[louilinn]

Can we convert this PR back to Draft as it is not ready or in a state to be merged?

I would appreciate if we squash miko's commits (using git rebase --interactive) here into one commit before merging this PR (not before tonight but when you are not all working on the branch at once). This is to have a reference commit to know what changed in myxo. Long term we have to make this fix in the core. Miko is creating an issue for it now.

[louilinn]

Also please note that all changes to error messages will have to be OK:d by @triaslucia before merging.

For reference Lucia, this is the code branch that is in preview-testing and will be tested by selected business partners in a meeting tonight.
I suggest that we make a comment in this PR explicitely stating our suggested changes of the transaction errors in a before/after manner so she can easily review.
(No action necessary from your side @triaslucia until we tag you again)

[louilinn]

Related: CirclesUBI/circles-core#188

[triaslucia]

I am not sure if I can reproduce all scenarios to se the error msg. Is there not documentation of them as text?

I only see one msg, in all cases:

We should correct the text on the hoover of the spinning wheel:

We are tracing the trust connections between both wallets, in order to calculate your maximum transfer limit.

[JacqueGM]

@triaslucia - is your last comment something to be fixed before merging or can we merge opening an issue about it?

[llunaCreixent]

Can we convert this PR back to Draft as it is not ready or in a state to be merged?

I would appreciate if we squash miko's commits (using git rebase --interactive) here into one commit before merging this PR (not before tonight but when you are not all working on the branch at once). This is to have a reference commit to know what changed in myxo. Long term we have to make this fix in the core. Miko is creating an issue for it now.

I think miko's work should have been added in a new PR. Anyway, can you please @mikozet add the description of what is done into the description of this PR?

[llunaCreixent]

Can we convert this PR back to Draft as it is not ready or in a state to be merged?

I would appreciate if we squash miko's commits (using git rebase --interactive) here into one commit before merging this PR (not before tonight but when you are not all working on the branch at once). This is to have a reference commit to know what changed in myxo. Long term we have to make this fix in the core. Miko is creating an issue for it now.

Which commit do you want to squash?

[mikozet]

I think miko's work should have been added in a new PR. Anyway, can you please @mikozet add the description of what is done into the description of this PR?

"Add an exception when txHash is null" - added to description

[louilinn]

So this is no longer a draft or?

[louilinn]

I am not sure if I can reproduce all scenarios to se the error msg. Is there not documentation of them as text?

I only see one msg, in all cases:

We should correct the text on the hoover of the spinning wheel:

We are tracing the trust connections between both wallets, in order to calculate your maximum transfer limit.

this is part of the send confirm view that I'm still waiting for, we will fix that then