-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lathe/Design/Materials refactoring + misc changes #5123
Merged
TheLordME
merged 180 commits into
Citadel-Station-13:master
from
silicons:lathe_refactor
Jul 8, 2023
Merged
Lathe/Design/Materials refactoring + misc changes #5123
TheLordME
merged 180 commits into
Citadel-Station-13:master
from
silicons:lathe_refactor
Jul 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Mar 2, 2023
TheLordME
previously approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
citadel.dme: Large diffs are not rendered by default
TheLordME
approved these changes
Jul 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still wont load citadel.dme, you know this is a great PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
The Massive Refactor of The Week
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
rewrites lathes
they are now embeddable within other interfaces, have unified controls + queue management, and have support for using
rewrites /datum/design to be semi-singletons
adds SSresearch to hold designs
rewrites atom material system a bit
also:
Why It's Good For The Game
lathes sorely needed a redo
we want good materials support ontop of that.
also fixes autolathes :)
the "also" part is already covered above.
Changelog
🆑
refactor: lathes are completely rewritten
fix: autolathe x5 and x10 buttons
del: autolathes can no longer be hacked. all hacked recipes are instead accessible as normal recipes.
del: partslathes - redundant
del: id restoration consoles - unused / prohibited by server rules
/:cl: