Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lathe/Design/Materials refactoring + misc changes #5123

Merged
merged 180 commits into from
Jul 8, 2023

Conversation

silicons
Copy link
Contributor

@silicons silicons commented Mar 2, 2023

About The Pull Request

rewrites lathes
they are now embeddable within other interfaces, have unified controls + queue management, and have support for using

  • materials
  • reagents
  • even using / transforming existing items

rewrites /datum/design to be semi-singletons
adds SSresearch to hold designs
rewrites atom material system a bit

also:

  • adds MIT license identifiers to some of my old TGUI work of which I am the only one on the git history. i'd like to keep the tgui section and my own code samples in there as MIT instead of AGPL.
  • removes vorestation id restorers from maps because they're unused nowadays
  • removes partslathe as they're basically just unused
  • Revamps sheetmaterials stylesheet as it really didn't need to just be stacks.dmi

Why It's Good For The Game

lathes sorely needed a redo
we want good materials support ontop of that.
also fixes autolathes :)

the "also" part is already covered above.

Changelog

🆑
refactor: lathes are completely rewritten
fix: autolathe x5 and x10 buttons
del: autolathes can no longer be hacked. all hacked recipes are instead accessible as normal recipes.
del: partslathes - redundant
del: id restoration consoles - unused / prohibited by server rules
/:cl:

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 2, 2023
@silicons silicons changed the title Lathe Rewrite Lathe Rewrite / Design Rewrite Mar 2, 2023
TheLordME
TheLordME previously approved these changes Jul 5, 2023
Copy link
Collaborator

@TheLordME TheLordME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

citadel.dme: Large diffs are not rendered by default

Copy link
Collaborator

@TheLordME TheLordME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still wont load citadel.dme, you know this is a great PR

@TheLordME TheLordME merged commit 749579b into Citadel-Station-13:master Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. The Massive Refactor of The Week
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants