Baylike Walls and Windows #5547
Conversation
github-actions
bot
added
the
size/L
github-actions
bot
added
size/XXL
|
finally, i can quit |
|
…l-Station-13-RP into great_perspective
…o great_perspective
|
love how map changes turn my diffs into +10,000 line monstrosities. |
| @@ -0,0 +1,3 @@ | |||
| #define BITSHIFT_LEFT(X, N) (X << (N)) | |||
| #define BITSHIFT_RIGHT(X, N) (X >> (N)) | |||
| #define BITFLAG(X) BITSHIFT_LEFT(1, X) | |||
There was a problem hiding this comment.
why do we need these defines?
bitshifts are a pretty fundamental thing
i don't think it should be behind a #define, especially when it's longer to type the define out in most cases.
| //color = "" | ||
|
|
||
| /obj/machinery/door/airlock/security/armory/allowed(mob/user) | ||
| if(get_security_level() in list("green","blue")) |
There was a problem hiding this comment.
y' sure about this? shouldn't hos/whoever be able to get in? or is this the "public" door?
There was a problem hiding this comment.
i think this code already exists. it just shows up as something new because i moved all the subtypes and their shit to a new file.
Mazianni
force-pushed
the
great_perspective
branch
from
dc01891
to
ce4a4f1
Compare
| switch(D) | ||
| if(NORTH) | ||
| dir = WEST | ||
| break | ||
| if(EAST) | ||
| dir = SOUTH | ||
| break | ||
| if(SOUTH) | ||
| dir = WEST | ||
| break | ||
| if(WEST) | ||
| dir = SOUTH | ||
| break | ||
| if(T.density) | ||
| switch(D) | ||
| if(NORTH) | ||
| dir = WEST | ||
| break | ||
| if(EAST) | ||
| dir = SOUTH | ||
| break | ||
| if(SOUTH) | ||
| dir = WEST | ||
| break | ||
| if(WEST) | ||
| dir = SOUTH | ||
| break |
There was a problem hiding this comment.
dir setting code should be before the . =..() and instead set ndir, so the proc itself sets it
setting ndir will make this happen because args are just passed down the ..() instead of copied so by re-setting an arg, it's propagating down.
directly dir setting after ..() will break things that rely on this behavior
| /obj/structure/wall_frame/CanPass(atom/movable/mover, turf/target, height=0, air_group=0) | ||
| if(air_group || (height==0)) return 1 | ||
| if(istype(mover,/obj/projectile)) | ||
| return 1 | ||
| if(istype(mover) && mover.check_pass_flags(ATOM_PASS_TABLE)) | ||
| return 1 |
There was a problem hiding this comment.
our canPass doesn't touch ZAS, check the root definition of CanPass and use that; don't worry about atmos pass, that's already handled by /obj/structure's defaults.
…el-Station-13-RP into great_perspective
About The Pull Request
Largely a port of code from Daedalus Dock and icons from Bay/Nebula. Lots of things need to be touched with this.
Why It's Good For The Game
It just looks better, imho.
Changelog
🆑
/:cl: