Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baylike Walls and Windows #5547
Baylike Walls and Windows #5547
Changes from 29 commits
64abb63
36719ef
3b3464e
f42877b
6fcb622
302a254
1ade880
66e581b
a70843f
dee46e7
a620c9a
d421389
b63a83f
417452e
805b8f3
b6329d7
20b8f10
f4eb91e
ddf258b
59a30f1
479a72d
5008500
37b4ec9
2e8d7e2
43ac714
fcc62c4
5471179
dbc4e8a
30c7a73
0f55992
6d2f957
6c82d1e
071c1b3
272bab6
7845df9
37f0f57
ee6a615
22e834a
51c306d
93563e6
5ffa43c
ef5a8cf
ebd939e
7b486f7
ce4a4f1
e7d3435
a178030
6514bf2
806111a
afe9841
873e024
66ede5b
5ee7928
9954b50
842d07f
f8ad672
4c84253
e36c593
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need these defines?
bitshifts are a pretty fundamental thing
i don't think it should be behind a #define, especially when it's longer to type the define out in most cases.