Hds 2396 core scss v4 for checkbox #1370
Open
+11,739
−7,450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe to add CommonHTMLAttributes as data-* to props.
The arrow icon takes now space. Therefore it needed a background color and container and aligner elements.
…date The old command has rimraf which removes all images.
Include showArrow and information -props to the component props
…from Table Heading id is created when needed Table id was for checkbox and it is also created when needed. Updated docs, tests and snapshot.
Better usage of core css. Cannot use compose in core, so not-so-inconvenient "helper-text-gap" was added.
…exists Short HelperText stays on same line as ErrorText
Flexbox change requires label + tooltip combination to be wrapped. Made external components or otherwise focus would be lost from tooltip button on re-render, if anonymous functions were used.
Release-4.0.0: (HDS-2405) e2e test helper
Release-4.0.0: (HDS-2421) Storybook files typescript checking
…ts, add body spacing to helper for body-overflowing pages
Release-4.0.0 HDS-2425 hero changes
…ight-test-separate-running Release-4.0.0 HDS-2423 enable playwright test separate running and write instructions
…-native-attributes release-4.0.0 HDS-2388 icon template native attributes
…ft-right-to-start-end Release-4.0.0 (HDS-2420) Dialog, Header and StatusLabel icon-props renamed
Release-4.0.0 HDS-2272 fix koros examples, remova old and add new visual tests
Removed aria-label descripiton when not necessary or useful.
|
Preview found from hds-demo docs/preview_1370 Demos |
Test Results 1 files 26 suites 4m 20s ⏱️ Results for commit dc89665. ♻️ This comment has been updated with latest results. |
Release-4.0.0: (HDS-2390) remove ariaLabel and dataTestId
timwessman
force-pushed
the
hds-2396-core-scss-v4-for-checkbox
branch
from
ac4d013
to
55bde63
Compare
|
Hmm... wonder why the visual tests fail for SelectionGroup 🤔 |
NikoHelle
force-pushed
the
release-4.0.0
branch
from
e33d8e6
to
d48fe2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE:
SelectionGroup. I can't find out why. The failingSelectrionGroup-story looks pixel perfect in Storybook, but on visual-test, margin between helper-text and checkboxes are couple of pixels smaller than it should.Related Issue
Closes HDS-2396
How Has This Been Tested?
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog