Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hds 2396 core scss v4 for checkbox #1370

Open
wants to merge 103 commits into
base: release-4.0.0
Choose a base branch
from

Commits on Sep 5, 2024

  1. release-4.0.0) (HDS-2124) new tag

    mrTuomoK authored and NikoHelle committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    09fc88b View commit details
    Browse the repository at this point in the history
  2. release-4.0.0) (HDS-2191) new button

    mrTuomoK authored and NikoHelle committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5172a56 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dcfdd80 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ab14f14 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    31e1d6e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cea4cab View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    492af7f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    87d26fa View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2330152 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d40df4f View commit details
    Browse the repository at this point in the history
  11. release-4.0.0) () fix giving html props in TagProps and add helper Ty…

    …pe to add CommonHTMLAttributes as data-* to props.
    mrTuomoK authored and NikoHelle committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6d40975 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    f827b6f View commit details
    Browse the repository at this point in the history
  2. release-4.0.0) (hds-2103) New information element to hero in core

    The arrow icon takes now space. Therefore it needed a background color and container and aligner elements.
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    62b670d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f64a779 View commit details
    Browse the repository at this point in the history
  4. release-4.0.0) (hds-2103) Update script for single story reference up…

    …date
    
    The old command has rimraf which removes all images.
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7212021 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2a125bc View commit details
    Browse the repository at this point in the history
  6. release-4.0.0) (hds-2103) Adjust Hero playground options

    Include showArrow and information -props to the component props
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d18b112 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    64e7c2b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ae9953c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    810c61a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    931e3ef View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e2f5a4c View commit details
    Browse the repository at this point in the history
  12. release-4.0.0) (hds-2062) Remove default id and headingId attributes …

    …from Table
    
    Heading id is created when needed
    Table id was for checkbox and it is also created when needed.
    
    Updated docs, tests and snapshot.
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    33f4121 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    d8435a5 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    79d6fac View commit details
    Browse the repository at this point in the history
  15. release-4.0.0) (hds-2273) Fix gaps and spacing in SelectionGroup

    Better usage of core css.
    
    Cannot use compose in core, so not-so-inconvenient "helper-text-gap" was added.
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    678491e View commit details
    Browse the repository at this point in the history
  16. release-4.0.0) (hds-2273) Fix issue when ErrorText and HelperText co-…

    …exists
    
    Short HelperText stays on same line as ErrorText
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    73b703e View commit details
    Browse the repository at this point in the history
  17. release-4.0.0) (hds-2273) Use label styles from core

    Flexbox change requires label + tooltip combination to be wrapped.
    
    Made external components or otherwise focus would be lost from tooltip button on re-render, if anonymous functions were used.
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3a941d6 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    e4cc38f View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    6527a95 View commit details
    Browse the repository at this point in the history
  20. release-4.0.0) (hds-2198) Update line-height docs

    Changed two lines. Lots of auto-formatting that haven't been applied before.
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b6d8dbf View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    fe5375d View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    55d246e View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    9aa2841 View commit details
    Browse the repository at this point in the history
  24. release-4.0.0) (hds-2215) Remove "black" header title variant

    It cannot be used via React ActionBar props,so it is useless. Verified with designers too.
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1cc3e85 View commit details
    Browse the repository at this point in the history
  25. release-4.0.0) (hds-2215) Faux css to scss converter

    Core has no scss so React cannot import partial css classes from Core and they have be duplicated.
    
    Helpers.css is converted to helpers.scss where  .className is converted to @mixin className
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    8cf27cd View commit details
    Browse the repository at this point in the history
  26. release-4.0.0) (hds-2215) Use core heading styles in React Header

    Header has 3 sizes: large, medium, small. Medium and small are the same (heading-s) except different letter-spacing.
    
    There is a bold-variant of each too.
    
    Line-height was already set to "--lineheight-s" in all variants. Most likely to align vertically. Did not change that.
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    153dc7d View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    a1f6cf9 View commit details
    Browse the repository at this point in the history
  28. release-4.0.0) (hds-2215) Adjust heading styles in other files with s…

    …ame font-size
    
    VSCode also auto-formatted chaged files.
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b6925eb View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    a47da7e View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    200ed89 View commit details
    Browse the repository at this point in the history
  31. release-4.0.0) (hds-2215) Rollup PostCSS to find monorepo node_modules

    Some npm packages are in "./node_modules" and some in root "../../node_modules"
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5ab50b1 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    108b99a View commit details
    Browse the repository at this point in the history
  33. release-4.0.0) (hds-2060) Change active Pagination item to span in React

    Made also some code simplifications/clarifications.
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    40a2495 View commit details
    Browse the repository at this point in the history
  34. release-4.0.0) (hds-2060) Handle focus when re-rendered

    Active element changes from <a> to <span>, so focus is lost after re-render.
    
    Re-focus the active element manually.
    NikoHelle committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b08fc1c View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    8b16a56 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    1e581db View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    53ff927 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    cc6aac5 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    aa080c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Configuration menu
    Copy the full SHA
    66b73ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c743b87 View commit details
    Browse the repository at this point in the history
  3. release-4.0.0 Rebasing fixes

    Some files had reverted changes.
    NikoHelle committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d61afff View commit details
    Browse the repository at this point in the history
  4. (hds-2297) Installed packages

    - cssTools/post-sass is plugin for postcss
    - postcss-sass handles syntax (recommended by post-sass)
    NikoHelle committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b129ebc View commit details
    Browse the repository at this point in the history
  5. (hds-2297) Updated core configs

    Same stylelint scss config as React package has
    NikoHelle committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    82d9f9a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f1eaf1c View commit details
    Browse the repository at this point in the history
  7. (hds-2297) Add scss support to core Storybook

    Using deprecated @storybook/preset-scss, because current Storybook is old v6.
    
    Other added packages were added because the preset-scss documentation instructs to do so.
    NikoHelle committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a2c60d7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ece4bf3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2b288d0 View commit details
    Browse the repository at this point in the history
  10. (hds-2297) Added BEM helper for Sass

    The module could not be found because it was installed outside of "core", so copied the module. It has not changed for years, so updates not expected.
    NikoHelle committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    46abd1a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c8c8fd7 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a860a0e View commit details
    Browse the repository at this point in the history
  13. (hds-2297) Documentation

    NikoHelle committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ff92cbf View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    7d2cbb0 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    08ea63d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    26ab890 View commit details
    Browse the repository at this point in the history
  17. (HDS-2348) modify playwright tests to include core, move and rename r…

    …eact tests to react-* and core added to core-*, add core build to workflow
    mrTuomoK committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e9f4819 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Merge pull request #1338 from City-of-Helsinki/hds-2297-core-scss-v4

    Release-4.0.0: (hds-2297) SCSS compiler to core
    NikoHelle authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3e48507 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1355 from City-of-Helsinki/HDS-2389-old-analytics…

    …-removal
    
    release-4.0.0 (HDS-2389) remove old analytics
    mrTuomoK authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    47ef46d View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1356 from City-of-Helsinki/HDS-2348-core-playwrig…

    …ht-tests
    
    release-4.0.0 HDS-2348 core playwright tests
    mrTuomoK authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    79553d3 View commit details
    Browse the repository at this point in the history
  4. (hds-2421) Fix how tsc is run.

    Missing "yarn" before tsc causes it to be run globally
    NikoHelle committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    253cad8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2ce3273 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Merge pull request #1354 from City-of-Helsinki/HDS-2358-button-conten…

    …t-align-fix
    
    release-4.0.0 HDS-2358 button content align fix
    mrTuomoK authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    04266e3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c91727 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8595956 View commit details
    Browse the repository at this point in the history
  4. (hds-2421) Fix newly introduced ts errors

    Notification errors only show with ts-check-stories. Caused by incompatible child types. Unknown why ts-check does not show it, or VSCode.
    NikoHelle committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    888020b View commit details
    Browse the repository at this point in the history
  5. (hds-2421) Updated ref images

    Dialog icon was not shown before
    NikoHelle committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7ee5616 View commit details
    Browse the repository at this point in the history
  6. (hds-2405) Add one helper to take all snapshots

    Added only takeAllStorySnapshots, other changes are from prettier.
    NikoHelle committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7ca3e96 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b0582ee View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f24d455 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d590fff View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ccd2d7e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge pull request #1362 from City-of-Helsinki/hds-2405-table-scss

    Release-4.0.0: (HDS-2405) e2e test helper
    NikoHelle authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a184f4d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1361 from City-of-Helsinki/hds-2421-stories-ts-check

    Release-4.0.0: (HDS-2421) Storybook files typescript checking
    NikoHelle authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    540de42 View commit details
    Browse the repository at this point in the history
  3. (HDS-2425) modify hero css, remove old loki tests, add playwright tes…

    …ts, add body spacing to helper for body-overflowing pages
    mrTuomoK committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    69edf28 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    24da05d View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge pull request #1364 from City-of-Helsinki/HDS-2425-hero-changes

    Release-4.0.0 HDS-2425 hero changes
    mrTuomoK authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1fb0557 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6aa54c9 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1363 from City-of-Helsinki/HDS-2423-enable-playwr…

    …ight-test-separate-running
    
    Release-4.0.0 HDS-2423 enable playwright test separate running and write instructions
    mrTuomoK authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    afa1175 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    67273dd View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1360 from City-of-Helsinki/HDS-2388-icon-template…

    …-native-attributes
    
    release-4.0.0 HDS-2388 icon template native attributes
    mrTuomoK authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d7ae3ae View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d896662 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #1365 from City-of-Helsinki/HDS-2420-change-all-le…

    …ft-right-to-start-end
    
    Release-4.0.0 (HDS-2420) Dialog, Header and StatusLabel icon-props renamed
    mrTuomoK authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e5ad4da View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Merge pull request #1366 from City-of-Helsinki/HDS-2272-fix-koros

    Release-4.0.0 HDS-2272 fix koros examples, remova old and add new visual tests
    mrTuomoK authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6c540cc View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Configuration menu
    Copy the full SHA
    37e87aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1c565e4 View commit details
    Browse the repository at this point in the history
  3. (hds-2390) Update docs

    Removed aria-label descripiton when not necessary or useful.
    NikoHelle committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    bc79434 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    015be6e View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge pull request #1359 from City-of-Helsinki/hds-2390-rm-attributes

    Release-4.0.0: (HDS-2390) remove ariaLabel and dataTestId
    NikoHelle authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e33d8e6 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Configuration menu
    Copy the full SHA
    c746742 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    55bde63 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    087b849 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Configuration menu
    Copy the full SHA
    dc89665 View commit details
    Browse the repository at this point in the history